kafka-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jun Rao (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (KAFKA-683) Fix correlation ids in all requests sent to kafka
Date Wed, 30 Jan 2013 16:05:12 GMT

    [ https://issues.apache.org/jira/browse/KAFKA-683?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13566563#comment-13566563
] 

Jun Rao commented on KAFKA-683:
-------------------------------

Yes, the main changes were made by me in kafka-203. If we want to track the time per request,
we have to somehow know the request type and potentially other fields (e.g., to distinguish
a replica fetch request and a consumer fetch request). If there is a better way to do this,
I'd be happy to make the change.

On second thought, is deserializing request in RequestChannel really bad? After all, it is
supposed to be a request channel and putting request objects into it seems to makes sense
too. This basically puts the deserialization overhead into the network threads instead of
the API threads, which may not be ideal. However, the deserialization overhead should be small.
                
> Fix correlation ids in all requests sent to kafka
> -------------------------------------------------
>
>                 Key: KAFKA-683
>                 URL: https://issues.apache.org/jira/browse/KAFKA-683
>             Project: Kafka
>          Issue Type: Improvement
>    Affects Versions: 0.8
>            Reporter: Neha Narkhede
>            Assignee: Neha Narkhede
>            Priority: Critical
>              Labels: improvement, replication
>         Attachments: kafka-683-v1.patch, kafka-683-v2.patch, kafka-683-v2-rebased.patch,
kafka-683-v2-rebased-twice.patch, kafka-683-v3.patch, kafka-683-v3-unit-test.patch
>
>
> We should fix the correlation ids in every request sent to Kafka and fix the request
log on the broker to specify not only the type of request and who sent it, but also the correlation
id. This will be very helpful while troubleshooting problems in production.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message