kafka-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Neha Narkhede (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (KAFKA-671) DelayedProduce requests should not hold full producer request data
Date Tue, 29 Jan 2013 19:21:16 GMT

    [ https://issues.apache.org/jira/browse/KAFKA-671?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13565679#comment-13565679
] 

Neha Narkhede commented on KAFKA-671:
-------------------------------------

Thanks for the v2 patch, few review comments -

1. kafka-run-class
Revert these changes, the default heap size of 5g is too large. Also for the GC configs, there
is another JIRA tracking it.
2. ProducerRequest
How about renaming emptyData() to clear() for consistency ?
3. What is the purpose of the mutable map changes in DefaultEventHandler ?

                
> DelayedProduce requests should not hold full producer request data
> ------------------------------------------------------------------
>
>                 Key: KAFKA-671
>                 URL: https://issues.apache.org/jira/browse/KAFKA-671
>             Project: Kafka
>          Issue Type: Bug
>    Affects Versions: 0.8
>            Reporter: Joel Koshy
>            Assignee: Sriram Subramanian
>            Priority: Blocker
>              Labels: bugs, p1
>             Fix For: 0.8.1
>
>         Attachments: outOfMemFix-v1.patch, outOfMemFix-v2.patch, outOfMemFix-v2-rebase.patch
>
>
> Per summary, this leads to unnecessary memory usage.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message