kafka-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sriram Subramanian (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (KAFKA-671) DelayedProduce requests should not hold full producer request data
Date Mon, 21 Jan 2013 00:38:12 GMT

    [ https://issues.apache.org/jira/browse/KAFKA-671?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13558462#comment-13558462
] 

Sriram Subramanian commented on KAFKA-671:
------------------------------------------

I think to do this right we should limit the change to produceRequest instead of getting rid
of the requestobj completely. The reason is as you mention you would need to cache a bunch
of fields from requestObj to be used in updateRequestMetrics while sending the response. This
can be two fields today but going forward you may need more fields and this would need to
be constantly maintained. I think if produceRequest handles data being null, the fix would
be more robust and isolates the changes within produce request.
                
> DelayedProduce requests should not hold full producer request data
> ------------------------------------------------------------------
>
>                 Key: KAFKA-671
>                 URL: https://issues.apache.org/jira/browse/KAFKA-671
>             Project: Kafka
>          Issue Type: Bug
>    Affects Versions: 0.8
>            Reporter: Joel Koshy
>            Assignee: Sriram Subramanian
>            Priority: Blocker
>             Fix For: 0.8.1
>
>         Attachments: outOfMemFix-v1.patch
>
>
> Per summary, this leads to unnecessary memory usage.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message