kafka-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Neha Narkhede (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (KAFKA-671) DelayedProduce requests should not hold full producer request data
Date Tue, 15 Jan 2013 18:54:15 GMT

    [ https://issues.apache.org/jira/browse/KAFKA-671?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13554142#comment-13554142
] 

Neha Narkhede commented on KAFKA-671:
-------------------------------------

Overall, the changes look good. Minor suggestions -

1. KafkaApis
1.1 Can we rename messageSizeInBytes to messageSetSize ?
1.2 Similarly rename messageSizes to messageSetSize

2. ProducerRequest
I'm guessing the resetData() API is added with the goal of helping with garbage collection
? I think this might not be request since once the produce request is handled, whether or
not it entered the purgatory, it will be eligible for garbage collection
                
> DelayedProduce requests should not hold full producer request data
> ------------------------------------------------------------------
>
>                 Key: KAFKA-671
>                 URL: https://issues.apache.org/jira/browse/KAFKA-671
>             Project: Kafka
>          Issue Type: Bug
>    Affects Versions: 0.8
>            Reporter: Joel Koshy
>            Assignee: Sriram Subramanian
>            Priority: Blocker
>             Fix For: 0.8.1
>
>         Attachments: outOfMemFix-v1.patch
>
>
> Per summary, this leads to unnecessary memory usage.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message