kafka-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Swapnil Ghike (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (KAFKA-648) Use uniform convention for naming properties keys
Date Fri, 11 Jan 2013 23:56:13 GMT

    [ https://issues.apache.org/jira/browse/KAFKA-648?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13551666#comment-13551666
] 

Swapnil Ghike commented on KAFKA-648:
-------------------------------------

Will it make sense to create a Utils function to get the value of logDirs and move the require(logDirs.size
> 0) inside this function? Currently, that's the only require() call in KafkaConfig. This
new function will probably be too specific to logDirs though.
                
> Use uniform convention for naming properties keys 
> --------------------------------------------------
>
>                 Key: KAFKA-648
>                 URL: https://issues.apache.org/jira/browse/KAFKA-648
>             Project: Kafka
>          Issue Type: Bug
>    Affects Versions: 0.8
>            Reporter: Swapnil Ghike
>            Assignee: Sriram Subramanian
>            Priority: Blocker
>             Fix For: 0.8, 0.8.1
>
>         Attachments: configchanges-1.patch, configchanges-v2.patch, configchanges-v3.patch,
configchanges-v4.patch, configchanges-v5.patch, configchanges-v6.patch, configchanges-v6-rebased.patch
>
>
> Currently, the convention that we seem to use to get a property value in *Config is as
follows:
> val configVal = property.getType("config.val", ...) // dot is used to separate two words
in the key and the first letter of second word is capitalized in configVal.
> We should use similar convention for groupId, consumerId, clientId, correlationId.
> This change will probably be backward non-compatible.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message