Mailing-List: contact kafka-dev-help@incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: kafka-dev@incubator.apache.org
Date: Fri, 2 Nov 2012 04:34:12 +0000 (UTC)
From: "Jun Rao (JIRA)" <jira@apache.org>
To: kafka-dev@incubator.apache.org
Message-ID: <1898001624.59337.1351830852493.JavaMail.jiratomcat@arcas>
In-Reply-To: <1620105547.64398.1350577205537.JavaMail.jiratomcat@arcas>
Subject: [jira] [Commented] (KAFKA-577) extend DumpLogSegments to verify
 consistency btw data and index
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/KAFKA-577?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13489255#comment-13489255 ] 

Jun Rao commented on KAFKA-577:
-------------------------------

A couple of more comments for patch v4.

40. LinkedList is supposed to be used for manipulating links directly. We should just use List (immutable) instead. Also, instead of the following,

        misMatchesSeq = misMatchesSeq.:+((entry.offset + index.baseOffset, messageAndOffset.offset).asInstanceOf[(Int, Int)])

we should write

        misMatchesSeq :+= ((entry.offset + index.baseOffset, messageAndOffset.offset).asInstanceOf[(Int, Int)])

                
> extend DumpLogSegments to verify consistency btw data and index
> ---------------------------------------------------------------
>
>                 Key: KAFKA-577
>                 URL: https://issues.apache.org/jira/browse/KAFKA-577
>             Project: Kafka
>          Issue Type: Bug
>          Components: core
>    Affects Versions: 0.8
>            Reporter: Jun Rao
>              Labels: newbie, tools
>             Fix For: 0.8
>
>         Attachments: kafka_577_v1.diff, kafka_577_v2.diff, kafka_577_v3.diff, kafka_577_v4.diff
>
>   Original Estimate: 24h
>  Remaining Estimate: 24h
>
> It would be good to extend DumpLogSegments to do the following verification:
> 1. The offsets stored in the index match those in the log data.
> 2. The offsets in the data log is consecutive.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira