Return-Path: X-Original-To: apmail-incubator-kafka-dev-archive@minotaur.apache.org Delivered-To: apmail-incubator-kafka-dev-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 93D22D1E2 for ; Thu, 1 Nov 2012 21:50:14 +0000 (UTC) Received: (qmail 78834 invoked by uid 500); 1 Nov 2012 21:50:14 -0000 Delivered-To: apmail-incubator-kafka-dev-archive@incubator.apache.org Received: (qmail 78802 invoked by uid 500); 1 Nov 2012 21:50:14 -0000 Mailing-List: contact kafka-dev-help@incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: kafka-dev@incubator.apache.org Delivered-To: mailing list kafka-dev@incubator.apache.org Received: (qmail 78746 invoked by uid 99); 1 Nov 2012 21:50:14 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 01 Nov 2012 21:50:14 +0000 Date: Thu, 1 Nov 2012 21:50:14 +0000 (UTC) From: "Swapnil Ghike (JIRA)" To: kafka-dev@incubator.apache.org Message-ID: <1741194407.57994.1351806614283.JavaMail.jiratomcat@arcas> In-Reply-To: <1862224451.1512.1349379707937.JavaMail.jiratomcat@arcas> Subject: [jira] [Assigned] (KAFKA-546) Fix commit() in zk consumer for compressed messages MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/KAFKA-546?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Swapnil Ghike reassigned KAFKA-546: ----------------------------------- Assignee: Swapnil Ghike > Fix commit() in zk consumer for compressed messages > --------------------------------------------------- > > Key: KAFKA-546 > URL: https://issues.apache.org/jira/browse/KAFKA-546 > Project: Kafka > Issue Type: New Feature > Affects Versions: 0.8 > Reporter: Jay Kreps > Assignee: Swapnil Ghike > > In 0.7.x and earlier versions offsets were assigned by the byte location in the file. Because it wasn't possible to directly decompress from the middle of a compressed block, messages inside a compressed message set effectively had no offset. As a result the offset given to the consumer was always the offset of the wrapper message set. > In 0.8 after the logical offsets patch messages in a compressed set do have offsets. However the server still needs to fetch from the beginning of the compressed messageset (otherwise it can't be decompressed). As a result a commit() which occurs in the middle of a message set will still result in some duplicates. > This can be fixed in the ConsumerIterator by discarding messages smaller than the fetch offset rather than giving them to the consumer. This will make commit work correctly in the presence of compressed messages (finally). -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira