Return-Path: X-Original-To: apmail-incubator-kafka-dev-archive@minotaur.apache.org Delivered-To: apmail-incubator-kafka-dev-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id D0C31DCEC for ; Sun, 5 Aug 2012 22:06:02 +0000 (UTC) Received: (qmail 79167 invoked by uid 500); 5 Aug 2012 22:06:02 -0000 Delivered-To: apmail-incubator-kafka-dev-archive@incubator.apache.org Received: (qmail 79128 invoked by uid 500); 5 Aug 2012 22:06:02 -0000 Mailing-List: contact kafka-dev-help@incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: kafka-dev@incubator.apache.org Delivered-To: mailing list kafka-dev@incubator.apache.org Received: (qmail 79011 invoked by uid 99); 5 Aug 2012 22:06:02 -0000 Received: from issues-vm.apache.org (HELO issues-vm) (140.211.11.160) by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 05 Aug 2012 22:06:02 +0000 Received: from isssues-vm.apache.org (localhost [127.0.0.1]) by issues-vm (Postfix) with ESMTP id 63F9F142822 for ; Sun, 5 Aug 2012 22:06:02 +0000 (UTC) Date: Sun, 5 Aug 2012 22:06:02 +0000 (UTC) From: "Jim Plush (JIRA)" To: kafka-dev@incubator.apache.org Message-ID: <872262556.15187.1344204362411.JavaMail.jiratomcat@issues-vm> In-Reply-To: <994987796.15185.1344204122509.JavaMail.jiratomcat@issues-vm> Subject: [jira] [Updated] (KAFKA-438) Code cleanup in MessageTest MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/KAFKA-438?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jim Plush updated KAFKA-438: ---------------------------- Fix Version/s: 0.8 Affects Version/s: 0.7.1 Status: Patch Available (was: Open) cleanup * was using HashMap when rest of codebase seems to prefix with mutable.HashMap * removed assignments from Unit response test functions e.g. removed the "=" > Code cleanup in MessageTest > --------------------------- > > Key: KAFKA-438 > URL: https://issues.apache.org/jira/browse/KAFKA-438 > Project: Kafka > Issue Type: Improvement > Components: core > Affects Versions: 0.7.1 > Reporter: Jim Plush > Priority: Trivial > Fix For: 0.8 > > Attachments: KAFKA-438 > > > While exploring the Unit Tests this class had an unused import statement, some ambiguity on which HashMap implementation was being used and assignments of function returns when not required. > Trivial stuff -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira