Mailing-List: contact kafka-dev-help@incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: kafka-dev@incubator.apache.org
Date: Thu, 9 Aug 2012 18:57:19 +0000 (UTC)
From: "Yang Ye (JIRA)" <jira@apache.org>
To: kafka-dev@incubator.apache.org
Message-ID: <1999374919.3123.1344538639193.JavaMail.jiratomcat@issues-vm>
In-Reply-To: <1895290545.24811.1338514162900.JavaMail.jiratomcat@issues-vm>
Subject: [jira] [Updated] (KAFKA-356) Create a generic Kafka thread class
 that includes basic boiler plate code of instantiating and shutting down
 threads cleanly
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


     [ https://issues.apache.org/jira/browse/KAFKA-356?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Yang Ye updated KAFKA-356:
--------------------------

    Attachment: kafka_356_v1.diff

Build a KafkaThread class which wraps shutting down with interruption and exception handling; and let the leaderFinderThread, AbstractFetcherThread and RequestSendThread classes extend it. 
                
> Create a generic Kafka thread class that includes basic boiler plate code of instantiating and shutting down threads cleanly
> ----------------------------------------------------------------------------------------------------------------------------
>
>                 Key: KAFKA-356
>                 URL: https://issues.apache.org/jira/browse/KAFKA-356
>             Project: Kafka
>          Issue Type: Sub-task
>    Affects Versions: 0.8
>            Reporter: Neha Narkhede
>            Assignee: Yang Ye
>         Attachments: kafka_356_v1.diff
>
>
> We have a lot of threads that basically run in a loop and use an isRunning atomic boolean and count down latch. It will be useful to refactor it out into a helper runnable that these can extend. Verifying the lifecycle details for each is kind of a pain and it pretty easy to either not cleanly shutdown all the threads.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira