kafka-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jun Rao (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (KAFKA-461) remove support for format for magic byte 0 in 0.8
Date Sat, 18 Aug 2012 05:13:38 GMT

    [ https://issues.apache.org/jira/browse/KAFKA-461?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13437245#comment-13437245
] 

Jun Rao commented on KAFKA-461:
-------------------------------

Thanks for the patch. A couple of comments:

1. Message: Let's remove the following comment:

 * If magic byte is 1

2. We need to remove the test resource core/src/test/resources/test-kafka-logs
                
> remove support for format for magic byte 0 in 0.8
> -------------------------------------------------
>
>                 Key: KAFKA-461
>                 URL: https://issues.apache.org/jira/browse/KAFKA-461
>             Project: Kafka
>          Issue Type: Bug
>          Components: core
>    Affects Versions: 0.8
>            Reporter: Jun Rao
>            Assignee: Swapnil Ghike
>              Labels: backward-incompatible, bugs
>             Fix For: 0.8
>
>         Attachments: kafka-461.patch
>
>   Original Estimate: 72h
>  Remaining Estimate: 72h
>
> Since 0.8 is a non-backward compatible release, should we remove the support for magic
byte 0 in Message and support only magic byte 1?

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message