kafka-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Yang Ye (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (KAFKA-349) Create individual "Response" types for each kind of request and wrap them with "BoundedByteBufferSend", remove "xxResponseSend" types for all requests except "FetchRequest"
Date Tue, 05 Jun 2012 23:07:22 GMT

     [ https://issues.apache.org/jira/browse/KAFKA-349?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Yang Ye updated KAFKA-349:
--------------------------

    Attachment: kafka_responseSend.patch.8

71. LeaderAndISRRequest:
71.1 constructor: can we put versionId and clientId before the rest of the fields?

did that

71.2 writeTo(): we should put versionId first and clientId second.

did that

72. KafkaApis: in handleLeaderAndISR() and handleStopReplica(), add a TODO comment that the
actually logic will be put in later.

did that


73: ProducerReponse.writeTo: Let's put correlationId before errorcode, to be consistent.

did that


74. ControllerToBrokerRequestTest seems to fail for me. You need to remove unit. from the
package name.

did that

75. ControllerToBrokerRequestTest should use TestUtils.createBrokerConfigs to create broker
properties.

did that


All tests passed on my local machine
                
> Create individual "Response" types for each kind of request and wrap them with "BoundedByteBufferSend",
remove "xxResponseSend" types for all requests except "FetchRequest"
> ----------------------------------------------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: KAFKA-349
>                 URL: https://issues.apache.org/jira/browse/KAFKA-349
>             Project: Kafka
>          Issue Type: Improvement
>            Reporter: Yang Ye
>            Assignee: Yang Ye
>         Attachments: kafka_responseSend.patch, kafka_responseSend.patch.2, kafka_responseSend.patch.3,
kafka_responseSend.patch.4, kafka_responseSend.patch.5, kafka_responseSend.patch.6, kafka_responseSend.patch.7,
kafka_responseSend.patch.8
>
>


--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message