kafka-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "John Fung (JIRA)" <j...@apache.org>
Subject [jira] [Comment Edited] (KAFKA-341) Create a new single host system test to validate all replicas on 0.8 branch
Date Mon, 11 Jun 2012 22:30:43 GMT

    [ https://issues.apache.org/jira/browse/KAFKA-341?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13293139#comment-13293139
] 

John Fung edited comment on KAFKA-341 at 6/11/12 10:29 PM:
-----------------------------------------------------------

Hi Jun, Joel,

Thanks for reviewing this patch. A v2 patch is attached to this JIRA. The following changes
are made according to your suggestions.


** Changes not made from Review Suggestions

1. An extra copy of kafka-run-class.sh is added to the bin directory of this specific test
folder because a customized copy of log4j.properties is required to enable some debugging
code in ConsoleConsumer and ProducerPerformance for checksum validation


** Changes made from Review Suggestions

1. Move common functions to a separate script at system_test\common\util.sh

2. Fixed typos (line 56 & 65 in previous version)

3. Rename *_source_cluster to *_cluster

4. README added

5. PASS or FAIL validation is added at the end of the test

6. Target cluster related code removed

7. All the "cut" are replaced with "awk"


** Other changes made

1. The script will check the no. of brokers required and generate the corresponding no. of
server.properties files

                
      was (Author: jfung):
    Changes not made from Review Suggestion

1. An extra copy of kafka-run-class.sh is added to the bin directory of this specific test
folder because a customized copy of log4j.properties is required to enable some debugging
code in ConsoleConsumer and ProducerPerformance for checksum validation

Changes made from Review Suggestion

1. Move common functions to a separate script at system_test\common\util.sh

2. Fixed typos (line 56 & 65 in previous version)

3. Rename *_source_cluster to *_cluster

4. README added

5. PASS or FAIL validation is added at the end of the test

6. Target cluster related code removed

7. All the "cut" are replaced with "awk"

Other changes made

1. The script will check the no. of brokers required and generate the corresponding no. of
server.properties files

                  
> Create a new single host system test to validate all replicas on 0.8 branch
> ---------------------------------------------------------------------------
>
>                 Key: KAFKA-341
>                 URL: https://issues.apache.org/jira/browse/KAFKA-341
>             Project: Kafka
>          Issue Type: Task
>            Reporter: John Fung
>            Assignee: John Fung
>         Attachments: kafka-341-v1.patch, kafka-341-v2.patch
>
>


--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message