kafka-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jun Rao (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (KAFKA-329) Remove the watches/broker for new topics and partitions and change create topic admin API to send start replica state change to all brokers
Date Mon, 11 Jun 2012 16:50:43 GMT

    [ https://issues.apache.org/jira/browse/KAFKA-329?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13292872#comment-13292872
] 

Jun Rao commented on KAFKA-329:
-------------------------------

Prashanth,

Thanks for patch. Some comments:

1. AdminUtils.createTopicPartitionAssignmentPathInZK(): In V3, we don't need the topic version
anymore. So, we don't need to store it in the ZK. 

2. KafkaZookeeper: For this patch, we can just keep the main logic the same as in V2 (i.e.,
assuming no controller). The only changes will be based on that (1) partition assignment is
stored in 1 ZK path per topic; (2) partitions and partition assignment never change after
created (such logic will be added later in the controller). So, we can keep subscribeToTopicAndPartitionsChanges(),
but obtain partition assignment from a different ZK path. Ditto for handleNewTopics. We can
punt on the handling of delete topics since there is a separate jira for that. We can get
rid of handleNewPartitions(). Most of the code in this class can probably be reused when we
move the logic to the controller.

                
> Remove the watches/broker for new topics and partitions and change create topic admin
API to send start replica state change to all brokers
> -------------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: KAFKA-329
>                 URL: https://issues.apache.org/jira/browse/KAFKA-329
>             Project: Kafka
>          Issue Type: Sub-task
>    Affects Versions: 0.8
>            Reporter: Neha Narkhede
>            Assignee: Prashanth Menon
>              Labels: replication
>         Attachments: KAFKA-329-DRAFT.patch
>
>
> Currently in 0.8, all brokers register a watch on /brokers/topics and /brokers/topics/[topic]
for all topics in a Kafka cluster. The watches are required to discover new topics. 
> There is another way this can be achieved, as proposed here - https://cwiki.apache.org/confluence/display/KAFKA/Kafka+replication+detailed+design+V2#KafkareplicationdetaileddesignV2-Createtopic
> Basically, the create-topic admin command sends start-replica state change request to
all brokers in the assigned replicas list.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message