kafka-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jun Rao (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (KAFKA-349) Create individual "Response" types for each kind of request and wrap them with "BoundedByteBufferSend", remove "xxResponseSend" types for all requests except "FetchRequest"
Date Sat, 02 Jun 2012 01:54:23 GMT

    [ https://issues.apache.org/jira/browse/KAFKA-349?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13287830#comment-13287830
] 

Jun Rao commented on KAFKA-349:
-------------------------------

Thanks for patch v7. Some comments:

71. LeaderAndISRRequest:
71.1 constructor: can we put versionId and clientId before the rest of the fields?
71.2 writeTo(): we should put versionId first and clientId second.

72. KafkaApis: in handleLeaderAndISR() and handleStopReplica(), add a TODO comment that the
actually logic will be put in later.

73: ProducerReponse.writeTo: Let's put correlationId before errorcode, to be consistent.

74. ControllerToBrokerRequestTest seems to fail for me. You need to remove unit. from the
package name.

                
> Create individual "Response" types for each kind of request and wrap them with "BoundedByteBufferSend",
remove "xxResponseSend" types for all requests except "FetchRequest"
> ----------------------------------------------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: KAFKA-349
>                 URL: https://issues.apache.org/jira/browse/KAFKA-349
>             Project: Kafka
>          Issue Type: Improvement
>            Reporter: Yang Ye
>            Assignee: Yang Ye
>         Attachments: kafka_responseSend.patch, kafka_responseSend.patch.2, kafka_responseSend.patch.3,
kafka_responseSend.patch.4, kafka_responseSend.patch.5, kafka_responseSend.patch.6, kafka_responseSend.patch.7
>
>


--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message