Mailing-List: contact kafka-dev-help@incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: kafka-dev@incubator.apache.org
Received-SPF: pass (athena.apache.org: domain of jay.kreps@gmail.com
 designates 209.85.210.175 as permitted sender)
MIME-Version: 1.0
Date: Sun, 25 Mar 2012 15:23:12 -0700
Message-ID: 
 <CAOeJiJikCfbobtNELXRdk4vXn3z3qNi9cjQwT0ajZZ6Kao=89w@mail.gmail.com>
Subject: kafka.utils.Utils
From: Jay Kreps <jay.kreps@gmail.com>
To: kafka-dev@incubator.apache.org
Content-Type: multipart/alternative; boundary=90e6ba61456a098aab04bc18b4a4

--90e6ba61456a098aab04bc18b4a4
Content-Type: text/plain; charset=ISO-8859-1

Hey guys,

The Utils helpers are meant to be generic non-kafka-specific utility
functions. Ideally it should not have dependencies outside java.* and
scala.*. I notice a lot of code in there that is zookeeper-specific (my
fault I think), that should really be a ZkUtils class. I also notice a lot
of code that isn't properly helper code at all but actually very
kafka-specific stuff.  This isn't a big deal, just a little hacky.

Here are some suspicious methods:

  def getCompressionCodec(props: Properties, codec: String):
CompressionCodec
  def getTopicRentionHours(retentionHours: String) : Map[String, Int]
  def getTopicFlushIntervals(allIntervals: String) : Map[String, Int]
  def getTopicPartitions(allPartitions: String) : Map[String, Int]
  def getConsumerTopicMap(consumerTopicString: String) : Map[String, Int]
  class SnapshotStats
  class Stats
  ...

In general if we are putting domain-specific logic into generic static
helpers like this it probably means we are missing some domain object to
stick these on.

I will file a ticket to clean these up, but I wanted to email around to try
to explain the motivation.

-Jay

--90e6ba61456a098aab04bc18b4a4--