Mailing-List: contact kafka-dev-help@incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: kafka-dev@incubator.apache.org
Received-SPF: pass (athena.apache.org: domain of chris.burroughs@gmail.com
 designates 209.85.216.175 as permitted sender)
Message-ID: <4F6FC64B.3050003@gmail.com>
Date: Sun, 25 Mar 2012 21:28:43 -0400
From: Chris Burroughs <chris.burroughs@gmail.com>
User-Agent: Mozilla/5.0 (X11; Linux x86_64;
 rv:10.0.2) Gecko/20120216 Thunderbird/10.0.2
MIME-Version: 1.0
To: kafka-dev@incubator.apache.org
CC: Jay Kreps <jay.kreps@gmail.com>
Subject: Re: kafka.utils.Utils
References: 
 <CAOeJiJikCfbobtNELXRdk4vXn3z3qNi9cjQwT0ajZZ6Kao=89w@mail.gmail.com>
In-Reply-To: 
 <CAOeJiJikCfbobtNELXRdk4vXn3z3qNi9cjQwT0ajZZ6Kao=89w@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit

It would also be nice if the truly generic ZKUtils
(createEphemeralPathExpectConflict) and the kafka specific
(getConsumersPerTopic) were in separate classes.

On 03/25/2012 06:23 PM, Jay Kreps wrote:
> Hey guys,
> 
> The Utils helpers are meant to be generic non-kafka-specific utility
> functions. Ideally it should not have dependencies outside java.* and
> scala.*. I notice a lot of code in there that is zookeeper-specific (my
> fault I think), that should really be a ZkUtils class. I also notice a lot
> of code that isn't properly helper code at all but actually very
> kafka-specific stuff.  This isn't a big deal, just a little hacky.
> 
> Here are some suspicious methods:
> 
>   def getCompressionCodec(props: Properties, codec: String):
> CompressionCodec
>   def getTopicRentionHours(retentionHours: String) : Map[String, Int]
>   def getTopicFlushIntervals(allIntervals: String) : Map[String, Int]
>   def getTopicPartitions(allPartitions: String) : Map[String, Int]
>   def getConsumerTopicMap(consumerTopicString: String) : Map[String, Int]
>   class SnapshotStats
>   class Stats
>   ...
> 
> In general if we are putting domain-specific logic into generic static
> helpers like this it probably means we are missing some domain object to
> stick these on.
> 
> I will file a ticket to clean these up, but I wanted to email around to try
> to explain the motivation.
> 
> -Jay
>