Return-Path: X-Original-To: apmail-incubator-kafka-dev-archive@minotaur.apache.org Delivered-To: apmail-incubator-kafka-dev-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 1742B90DA for ; Sat, 3 Mar 2012 03:34:27 +0000 (UTC) Received: (qmail 1572 invoked by uid 500); 3 Mar 2012 03:34:26 -0000 Delivered-To: apmail-incubator-kafka-dev-archive@incubator.apache.org Received: (qmail 1097 invoked by uid 500); 3 Mar 2012 03:34:24 -0000 Mailing-List: contact kafka-dev-help@incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: kafka-dev@incubator.apache.org Delivered-To: mailing list kafka-dev@incubator.apache.org Received: (qmail 1043 invoked by uid 99); 3 Mar 2012 03:34:22 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 03 Mar 2012 03:34:22 +0000 X-ASF-Spam-Status: No, hits=-2000.0 required=5.0 tests=ALL_TRUSTED,T_RP_MATCHES_RCVD X-Spam-Check-By: apache.org Received: from [140.211.11.116] (HELO hel.zones.apache.org) (140.211.11.116) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 03 Mar 2012 03:34:21 +0000 Received: from hel.zones.apache.org (hel.zones.apache.org [140.211.11.116]) by hel.zones.apache.org (Postfix) with ESMTP id 47D0E5E63 for ; Sat, 3 Mar 2012 03:34:01 +0000 (UTC) Date: Sat, 3 Mar 2012 03:34:01 +0000 (UTC) From: "Joe Stein (Commented) (JIRA)" To: kafka-dev@incubator.apache.org Message-ID: <338504508.17338.1330745641295.JavaMail.tomcat@hel.zones.apache.org> In-Reply-To: <1956214936.10937.1325789919235.JavaMail.tomcat@hel.zones.apache.org> Subject: [jira] [Commented] (KAFKA-240) implement new producer and consumer request format MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 X-Virus-Checked: Checked by ClamAV on apache.org [ https://issues.apache.org/jira/browse/KAFKA-240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13221495#comment-13221495 ] Joe Stein commented on KAFKA-240: --------------------------------- Thanks Jun, I get the issue now. Right, so after I read the byte buffer I need to return a ProducerRequest contructed with the versionId which right now is just dangling var. ok, got it. > implement new producer and consumer request format > -------------------------------------------------- > > Key: KAFKA-240 > URL: https://issues.apache.org/jira/browse/KAFKA-240 > Project: Kafka > Issue Type: Sub-task > Components: core > Affects Versions: 0.8 > Reporter: Jun Rao > Labels: fetch, replication, wireprotocol > Fix For: 0.8 > > Attachments: KAFKA-240-FetchRequest-v1.patch, KAFKA-240-FetchRequest-v2.patch, KAFKA-240-FetchRequest-validation-v1.patch, KAFKA-240.ProducerRequest.v2.patch, KAFKA-240.ProducerRequest.v3.patch, KAFKA-240.ProducerRequest.v4.patch, KAFKA-240.v3.patch, kafka-240_unittestfix_delta.patch > > > We want to change the producer/consumer request/response format according to the discussion in the following wiki: > https://cwiki.apache.org/confluence/display/KAFKA/New+Wire+Format+Proposal -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira