kafka-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Neha Narkhede (Commented) (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (KAFKA-239) Wire existing producer and consumer to use the new ZK data structure
Date Thu, 01 Mar 2012 18:37:58 GMT

    [ https://issues.apache.org/jira/browse/KAFKA-239?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13220226#comment-13220226
] 

Neha Narkhede commented on KAFKA-239:
-------------------------------------

>> 11. TestUtils: why do we need checkSetEqual? Doesn't scala do that by default? 

This is something you had added in the ZookeeperConsumerConnectorTest, not part of this patch.
I think Scala does it by default, and I'll clean it up as well.

>> 2. ZkUtils: rename idoesBrokerHostPartition to something like isPartitionOnBroker


I didn't see any grammatical difference between the two, but if you think the latter is easier
to understand, I'll incorporate the change

>> Unit tests seem to hang consistently for me. Seems to hang on testLatestOffsetResetForward(kafka.integration.AutoOffsetResetTest).


Please see my previous update on this JIRA, I've already identified that. Please wait for
another patch
                
> Wire existing producer and consumer to use the new ZK data structure
> --------------------------------------------------------------------
>
>                 Key: KAFKA-239
>                 URL: https://issues.apache.org/jira/browse/KAFKA-239
>             Project: Kafka
>          Issue Type: Sub-task
>          Components: core
>            Reporter: Jun Rao
>            Assignee: Neha Narkhede
>         Attachments: kafka-239-latest-revision-unit-tests-passing.patch, kafka-239-v2.patch,
kafka-239-v3.patch
>
>
> We can assume the leader of a partition is always the first replica. Data will only be
stored in the first replica. So, there is no fault-tolerance support yet. Just make the partition
logical.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message