Mailing-List: contact kafka-dev-help@incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: kafka-dev@incubator.apache.org
Received-SPF: pass (nike.apache.org: domain of cryptcom@gmail.com designates
 209.85.210.175 as permitted sender)
MIME-Version: 1.0
In-Reply-To: 
 <CAOG_4QbnUC+tVXpFtSB=eKLSCESF=-v2PR5cCmCQvd8rqVG85Q@mail.gmail.com>
References: 
 <CANEBM31VbnoCuXfcQz38CuwawwivjjDco63dJimRWDjFU=HPrA@mail.gmail.com>
	<CAOG_4QbnUC+tVXpFtSB=eKLSCESF=-v2PR5cCmCQvd8rqVG85Q@mail.gmail.com>
Date: Sun, 6 Nov 2011 01:50:13 -0500
Message-ID: 
 <CANEBM31ANHsBer8=PHOBWpcCEnyWcJ6eBDa8nu2GtAjJSHoYfA@mail.gmail.com>
Subject: Re: CompressionUtilTest does not run and fails when it does
From: Joe Stein <cryptcom@gmail.com>
To: kafka-dev@incubator.apache.org
Content-Type: multipart/alternative; boundary=90e6ba2123e59dfe2704b10b595e

--90e6ba2123e59dfe2704b10b595e
Content-Type: text/plain; charset=ISO-8859-1

ok

On Sun, Nov 6, 2011 at 1:40 AM, Neha Narkhede <neha.narkhede@gmail.com>wrote:

> Joe,
>
> Nice catch! This looks like a bug in the unit test. Do you want to
> file a JIRA and submit a patch ?
>
> Thanks,
> Neha
>
> On Sat, Nov 5, 2011 at 9:22 PM, Joe Stein <cryptcom@gmail.com> wrote:
> > CompressionUtilTest does not run the functions inside of it during ./sbt
> > test
> >
> > if you change CompressionUtilTest to extend JUnitSuite then the existing
> > functions run (once you adorne them with @Test) but then fail ...
> >
> > I suspect the TestUtils.checkEquals(messages.iterator,
> > decompressedMessages.iterator) is failing in testSimpleCompressDecompress
> > because all of the messages are serialized into byte arrays and the
> entire
> > set of messages compressed and that new compressed messages is what is
> > returned as one message instead of the List[Message] and therefor are not
> > interpreted within TestUtil.checkEquals to see this nuance.
> >
> > e.g.
> >
> > [error] Test Failed: testSimpleCompressDecompress
> > junit.framework.AssertionFailedError: expected:<message(magic = 1,
> > attributes = 0, crc = 3819140844, payload = java.nio.HeapByteBuffer[pos=0
> > lim=8 cap=8])> but was:<MessageAndOffset(message(magic = 1, attributes =
> 0,
> > crc = 3819140844, payload = java.nio.HeapByteBuffer[pos=0 lim=8
> cap=8]),18)>
> >
> > and
> >
> > [error] Test Failed: testComplexCompressDecompress
> > junit.framework.AssertionFailedError: expected:<2> but was:<3>
> >
> > Before opening a JIRA just wanted to check if maybe there was something
> > that I was missing?
> >
> > /*
> > Joe Stein
> > http://www.linkedin.com/in/charmalloc
> > Twitter: @allthingshadoop <http://www.twitter.com/allthingshadoop>
> > */
> >
>


-- 

/*
Joe Stein
http://www.linkedin.com/in/charmalloc
Twitter: @allthingshadoop <http://www.twitter.com/allthingshadoop>
*/

--90e6ba2123e59dfe2704b10b595e--