Return-Path: X-Original-To: apmail-incubator-kafka-dev-archive@minotaur.apache.org Delivered-To: apmail-incubator-kafka-dev-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 61D169D96 for ; Sun, 6 Nov 2011 18:58:15 +0000 (UTC) Received: (qmail 30179 invoked by uid 500); 6 Nov 2011 18:58:15 -0000 Delivered-To: apmail-incubator-kafka-dev-archive@incubator.apache.org Received: (qmail 30157 invoked by uid 500); 6 Nov 2011 18:58:15 -0000 Mailing-List: contact kafka-dev-help@incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: kafka-dev@incubator.apache.org Delivered-To: mailing list kafka-dev@incubator.apache.org Received: (qmail 30144 invoked by uid 99); 6 Nov 2011 18:58:15 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 06 Nov 2011 18:58:15 +0000 X-ASF-Spam-Status: No, hits=-2001.2 required=5.0 tests=ALL_TRUSTED,RP_MATCHES_RCVD X-Spam-Check-By: apache.org Received: from [140.211.11.116] (HELO hel.zones.apache.org) (140.211.11.116) by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 06 Nov 2011 18:58:12 +0000 Received: from hel.zones.apache.org (hel.zones.apache.org [140.211.11.116]) by hel.zones.apache.org (Postfix) with ESMTP id 0206934B1E for ; Sun, 6 Nov 2011 18:57:52 +0000 (UTC) Date: Sun, 6 Nov 2011 18:57:52 +0000 (UTC) From: "Neha Narkhede (Commented) (JIRA)" To: kafka-dev@incubator.apache.org Message-ID: <1461904138.5045.1320605872009.JavaMail.tomcat@hel.zones.apache.org> In-Reply-To: <1621367294.3291.1320516291765.JavaMail.tomcat@hel.zones.apache.org> Subject: [jira] [Commented] (KAFKA-187) Add Snappy Compression as a Codec MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 X-Virus-Checked: Checked by ClamAV on apache.org [ https://issues.apache.org/jira/browse/KAFKA-187?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13145074#comment-13145074 ] Neha Narkhede commented on KAFKA-187: ------------------------------------- 1. I think we might as well do the refactoring it as part of this patch. Copy pasting code doesn't seem like a good idea. 2. Yes. Same JIRA as this one. We might as well think through all the issues with supporting multiple codecs cleanly now, rather than later. 3. I've updated the perf patch. Do you want to submit a patch for the unit test ? > Add Snappy Compression as a Codec > --------------------------------- > > Key: KAFKA-187 > URL: https://issues.apache.org/jira/browse/KAFKA-187 > Project: Kafka > Issue Type: Improvement > Reporter: Joe Stein > Attachments: kafka-187.patch > > > My thoughts are a new trait CompressionDependencies for KafkaProject.scala, adding snappy as the first library -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira