kafka-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Neha Narkhede (Commented) (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (KAFKA-187) Add Snappy Compression as a Codec
Date Sun, 06 Nov 2011 06:56:51 GMT

    [ https://issues.apache.org/jira/browse/KAFKA-187?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13144946#comment-13144946
] 

Neha Narkhede commented on KAFKA-187:
-------------------------------------

1. There is quite a lot of overlap in the code for the GZIP and Snappy codec in CompressionUtils.
Wonder if you were up for refactoring it so that they use the same code path ?
2. One thing to think about is whether Snappy should be a compile and run time dependency
in the core kafka project. Especially since, GZIP will be default and Snappy will only be
used if it is explicitly configured. I wonder if there is any way of defining optional run
time dependencies ?
3. I think we will have to wait for the unit test to get fixed before accepting this patch.
Have you tried running the system and performance tests yet ? 
                
> Add Snappy Compression as a Codec
> ---------------------------------
>
>                 Key: KAFKA-187
>                 URL: https://issues.apache.org/jira/browse/KAFKA-187
>             Project: Kafka
>          Issue Type: Improvement
>            Reporter: Joe Stein
>         Attachments: kafka-187.patch
>
>
> My thoughts are a new trait CompressionDependencies for KafkaProject.scala, adding snappy
as the first library

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message