kafka-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jay Kreps (Created) (JIRA)" <j...@apache.org>
Subject [jira] [Created] (KAFKA-180) Clean up shell scripts
Date Tue, 01 Nov 2011 04:08:32 GMT
Clean up shell scripts
----------------------

                 Key: KAFKA-180
                 URL: https://issues.apache.org/jira/browse/KAFKA-180
             Project: Kafka
          Issue Type: Bug
            Reporter: Jay Kreps
            Assignee: Jay Kreps


Currently it is a bit of a mess:
jkreps-mn:kafka-git jkreps$ ls bin
kafka-console-consumer-log4j.properties	kafka-producer-perf-test.sh		kafka-server-stop.sh
		zookeeper-server-stop.sh
kafka-console-consumer.sh		kafka-producer-shell.sh			kafka-simple-consumer-perf-test.sh	zookeeper-shell.sh
kafka-console-producer.sh		kafka-replay-log-producer.sh		kafka-simple-consumer-shell.sh
kafka-consumer-perf-test.sh		kafka-run-class.sh			run-rat.sh
kafka-consumer-shell.sh			kafka-server-start.sh			zookeeper-server-start.sh

I think all the *-shell.sh scripts and all the *-simple-perf-test.sh scripts should die. If
anyone has a use for these test classes we can keep them around and use the via kafka-run-class,
but they are clearly not made for normal people to use. The *-shell.sh scripts are obsolete
now that we have the *-console-*.sh scripts, since these do everything the old scripts did
and more. I recommend we also delete the code for these.

I would like to change each tool so that it produces a usage line explaining what it does
when run without arguments. Currently I actually had to go read the code to figure out what
some of these are.

I would like to clean up places where the arguments are non-standard. Argument names should
be the same across all the tools.

I would also like to rename kafka-replay-log-producer.sh to kafka-copy-topic.sh. I think this
tool should also accept two zookeeper urls, the url of the input cluster and the url of the
output cluster so this tool can be used to copy between clusters. I think we can have a --zookeeper
a --input-zookeeper and a --output-zookeeper where --zookeeper is equivalent to setting both
the input and the output zookeeper. Also confused why the options for this list --brokerinfo
which can be either a zk url or brokerlist AND also --zookeeper which must be a zk url.

Any objections to all this? Any other gripes people have while I am in there?

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message