kafka-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Joe Stein (Commented) (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (KAFKA-187) Add Snappy Compression as a Codec
Date Sun, 06 Nov 2011 07:16:51 GMT

    [ https://issues.apache.org/jira/browse/KAFKA-187?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13144950#comment-13144950
] 

Joe Stein commented on KAFKA-187:
---------------------------------

{quote}

1. There is quite a lot of overlap in the code for the GZIP and Snappy codec in CompressionUtils.
Wonder if you were up for refactoring it so that they use the same code path ? 

{quote}

Agreed, I am.  Should I open a new ticket for refactoring CompressionUtils or just part of
this ticket?

{quote}

2. One thing to think about is whether Snappy should be a compile and run time dependency
in the core kafka project. Especially since, GZIP will be default and Snappy will only be
used if it is explicitly configured. I wonder if there is any way of defining optional run
time dependencies ? 

{quote}

Yeah, we could so something at startup that changes the default behavior to be a specific
codec.  Incorporating this into refactoring that class should not be a big deal where the
default case will check an object instead of implementing gzip (like it does now) and depending
on that object call either the gzip or snappy function i create (which will also get used
by the case match).  same JIRA as this?  a new JIRA for refactoring and put this into that?
 a third JIRA?

{quote}

3. I think we will have to wait for the unit test to get fixed before accepting this patch.
Have you tried running the system and performance tests yet ?

{quote}

Sounds good, I should be able to chip away at that tomorrow or early this week.  I did try
running the performance tests but ran into some errors.  it is possible something I was doing
wrong so I want to go through and set it up again before sending email about that.  same,
will try that in the next few days too.

                
> Add Snappy Compression as a Codec
> ---------------------------------
>
>                 Key: KAFKA-187
>                 URL: https://issues.apache.org/jira/browse/KAFKA-187
>             Project: Kafka
>          Issue Type: Improvement
>            Reporter: Joe Stein
>         Attachments: kafka-187.patch
>
>
> My thoughts are a new trait CompressionDependencies for KafkaProject.scala, adding snappy
as the first library

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message