Return-Path: 
 <jmeter-user-return-5846-apmail-jakarta-jmeter-user-archive=jakarta.apache.org@jakarta.apache.org>
Delivered-To: apmail-jakarta-jmeter-user-archive@www.apache.org
Received: (qmail 86909 invoked from network); 10 Sep 2004 14:25:25 -0000
Received: from hermes.apache.org (HELO mail.apache.org) (209.237.227.199)
  by minotaur-2.apache.org with SMTP; 10 Sep 2004 14:25:25 -0000
Received: (qmail 98031 invoked by uid 500); 10 Sep 2004 14:25:20 -0000
Delivered-To: apmail-jakarta-jmeter-user-archive@jakarta.apache.org
Received: (qmail 97952 invoked by uid 500); 10 Sep 2004 14:25:20 -0000
Mailing-List: contact jmeter-user-help@jakarta.apache.org; run by ezmlm
Precedence: bulk
List-Unsubscribe: <mailto:jmeter-user-unsubscribe@jakarta.apache.org>
List-Subscribe: <mailto:jmeter-user-subscribe@jakarta.apache.org>
List-Help: <mailto:jmeter-user-help@jakarta.apache.org>
List-Post: <mailto:jmeter-user@jakarta.apache.org>
List-Id: "JMeter Users List" <jmeter-user.jakarta.apache.org>
Reply-To: "JMeter Users List" <jmeter-user@jakarta.apache.org>
Delivered-To: mailing list jmeter-user@jakarta.apache.org
Received: (qmail 97725 invoked by uid 99); 10 Sep 2004 14:25:17 -0000
X-ASF-Spam-Status: No, hits=0.0 required=10.0
	tests=
X-Spam-Check-By: apache.org
Received-SPF: pass (hermes.apache.org: local policy)
Received: from [208.201.191.99] (HELO exchange1.wallstreetsystems.com)
 (208.201.191.99)
  by apache.org (qpsmtpd/0.28) with ESMTP; Fri, 10 Sep 2004 07:25:16 -0700
Received: by EXCHANGEI with Internet Mail Service (5.5.2657.72)
	id <R5SFQM7J>; Fri, 10 Sep 2004 10:22:49 -0400
Message-ID: <BE16CEA714128D47AAA2C2FC008BC51502218B67@EXCHANGEI>
From: Ed Randall <Ed.Randall@WallStreetSystems.com>
To: JMeter Users List <jmeter-user@jakarta.apache.org>
Subject: RE: Want to see stats on bandwidth / page sizes
Date: Fri, 10 Sep 2004 10:21:29 -0400
MIME-Version: 1.0
X-Mailer: Internet Mail Service (5.5.2657.72)
Content-Type: text/plain
X-Virus-Checked: Checked
X-Spam-Rating: minotaur-2.apache.org 1.6.2 0/1000/N

Yeah I'm just starting to realize my manager is gonna want more than 30
minutes 
effort ;-)

It only affects the "View Results In Table" screen at present, but some
stats
showing min/max/average response size and/or data rate in the aggregate
table
would be very nice indeed.

I'll see what more I can achieve this afternoon, but I'm in the UK, it's
Friday 
and I've been working late all week so planning to knock off within the next

hour ;-)

Regards

Ed

> -----Original Message-----
> From: Michael Stover [mailto:mstover1@apache.org] 
> Sent: 10 September 2004 15:33
> To: JMeter Users List
> Subject: RE: Want to see stats on bandwidth / page sizes
> 
> Which visualizers does your patch affect?  TableVisualizer?  
> Aggregate Report?  It'd be ideal if Aggregate Report also 
> showed a byte/second throughput measure.
> 
> -Mike
> 
> On Fri, 2004-09-10 at 10:04, Ed Randall wrote:
> > It has just taken me approx 30 minutes to get the source, configure 
> > eclipse,
> > 
> > and quickly hack through the code to find TableDataModel, I 
> added an 
> > extra column to it et voila!  I have a nice table with all of the 
> > numbers for the requests.  Then another 30 mins to do the 
> necessary to 
> > attach the patch diff and write this message!
> > 
> > I guess it's not exactly the nicest way to do it but it was 
> quick and 
> > it worked :-) It would be more flexible if addNewSample 
> simply added 
> > the SampleResult given by addSample then the model would have full 
> > access to everything, the panel containing the table could 
> then have a 
> > load of tick boxes for "what do you want to show".
> > 
> > Cheers
> > 
> > Ed
> > 
> > 
> > $ diff -C2 -w TableDataModel.java TableDataModel2.java
> > *** TableDataModel.java Thu Feb 12 19:48:46 2004
> > --- TableDataModel2.java        Fri Sep 10 15:02:57 2004
> > ***************
> > *** 46,49 ****
> > --- 46,50 ----
> >   
> >       List urlList = new ArrayList();
> > +     List respSizeList = new ArrayList();
> >   
> >       /**
> > ***************
> > *** 69,72 ****
> > --- 70,74 ----
> >           super.clear();
> >           urlList.clear();
> > +         respSizeList.clear();
> >       }
> >   
> > ***************
> > *** 85,93 ****
> >           long timeStamp,
> >           boolean success,
> > !         String url)
> >       {
> >           Sample s = super.addNewSample(time, timeStamp, success);
> >   
> >           urlList.add(url);
> >           return s;
> >       }
> > --- 87,97 ----
> >           long timeStamp,
> >           boolean success,
> > !         String url,
> > !         long respSize)
> >       {
> >           Sample s = super.addNewSample(time, timeStamp, success);
> >   
> >           urlList.add(url);
> > +         respSizeList.add(new Long(respSize));
> >           return s;
> >       }
> > ***************
> > *** 96,100 ****
> >       {
> >           Sample s = addNewSample(e.getTime(), e.getTimeStamp(), 
> > e.isSuccessful(),
> > !                 (String) e.getSampleLabel());
> >   
> >           fireDataChanged();
> > --- 100,104 ----
> >       {
> >           Sample s = addNewSample(e.getTime(), e.getTimeStamp(), 
> > e.isSuccessful(),
> > !                 (String) e.getSampleLabel(), 
> e.getResponseData().length);
> >   
> >           fireDataChanged();
> > ***************
> > *** 112,116 ****
> >       {
> >           // We have two columns : sampleNo and sampleValue
> > !         return 4;
> >       }
> >   
> > --- 116,120 ----
> >       {
> >           // We have 5 columns
> > !         return 5;
> >       }
> >   
> > ***************
> > *** 131,134 ****
> > --- 135,141 ----
> >               return JMeterUtils.getResString("Success?");
> >   
> > +         case 4:
> > +             return "Response size";
> > + 
> >           default:
> >               return null;
> > ***************
> > *** 154,157 ****
> > --- 161,168 ----
> >               return Boolean.class;
> >           }
> > +         else if (columnIndex == 4)
> > +         {
> > +             return Long.class;
> > +         }
> >           else
> >           {
> > ***************
> > *** 198,201 ****
> > --- 209,219 ----
> >               }
> >           }
> > +         else if (columnIndex == 4)
> > +         {
> > +             if ((rowIndex >= 0) && (rowIndex < 
> respSizeList.size()))
> > +             {
> > +                 return (Long)respSizeList.get(rowIndex);
> > +             }
> > +         }
> >           return null;
> >       }
> > 
> > 
> ---------------------------------------------------------------------
> > To unsubscribe, e-mail: jmeter-user-unsubscribe@jakarta.apache.org
> > For additional commands, e-mail: jmeter-user-help@jakarta.apache.org
> --
> Michael Stover <mstover1@apache.org>
> Apache Software Foundation
> 
> 
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: jmeter-user-unsubscribe@jakarta.apache.org
> For additional commands, e-mail: jmeter-user-help@jakarta.apache.org
> 

---------------------------------------------------------------------
To unsubscribe, e-mail: jmeter-user-unsubscribe@jakarta.apache.org
For additional commands, e-mail: jmeter-user-help@jakarta.apache.org