Mailing-List: contact dev-help@jmeter.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@jmeter.apache.org
MIME-Version: 1.0
In-Reply-To: <9c439aae-2815-80fd-4e5e-af90cdd8b661@internetallee.de>
References: <20161008152632.DEBB33A0233@svn01-us-west.apache.org>
 <CAOGo0Va0EeTbho4=4fO+kaw_K0sqGaC3cnROZYjkmE1RkzHJoA@mail.gmail.com>
 <9f27cf0d-c174-4ffb-7523-26844b167961@internetallee.de> <CAOGo0Vb+EKm1J6tJFc+7M2s5-+hV0Nma+Cx9PfhgS1YeqQ1aFg@mail.gmail.com>
 <2af3db3e-fb6c-fbda-0b01-c816c4e072d8@internetallee.de> <CAOGo0VYiG08MHHuYWaPjVzy6TAqdDeuGgY-A_c+-DyZT7Zpp7w@mail.gmail.com>
 <9c439aae-2815-80fd-4e5e-af90cdd8b661@internetallee.de>
From: sebb <sebbaz@gmail.com>
Date: Fri, 3 Mar 2017 18:34:08 +0000
Message-ID: <CAOGo0VYe8C-vXWeWeBC85JH9oCt-E=SsRGoodUPYbXJu+8HFgA@mail.gmail.com>
Subject: Re: svn commit: r1763904 - /jmeter/trunk/xdocs/stylesheets/site_printable.vsl
To: dev@jmeter.apache.org
Content-Type: text/plain; charset=UTF-8
archived-at: Fri, 03 Mar 2017 18:34:16 -0000

On 3 March 2017 at 18:24, Felix Schumacher
<felix.schumacher@internetallee.de> wrote:
> Am 03.03.2017 um 19:20 schrieb sebb:
>>
>> On 3 March 2017 at 18:07, Felix Schumacher
>> <felix.schumacher@internetallee.de> wrote:
>>>
>>> Am 03.03.2017 um 18:51 schrieb sebb:
>>>>
>>>> On 1 March 2017 at 17:37, Felix Schumacher
>>>> <felix.schumacher@internetallee.de> wrote:
>>>>>
>>>>> Am 01.03.2017 um 14:00 schrieb sebb:
>>>>>>
>>>>>> On 8 October 2016 at 16:26,  <fschumacher@apache.org> wrote:
>>>>>>>
>>>>>>> Author: fschumacher
>>>>>>> Date: Sat Oct  8 15:26:31 2016
>>>>>>> New Revision: 1763904
>>>>>>>
>>>>>>> URL: http://svn.apache.org/viewvc?rev=1763904&view=rev
>>>>>>> Log:
>>>>>>> Apply stylesheet recursively to code and source elements.
>>>>>>
>>>>>> -1
>>>>>>
>>>>>> Just discovered that this has broken several pages, for example
>>>>>>
>>>>>> get-started.html
>>>>>> 1.4.7 Logging and error messages
>>>>>
>>>>> I have applied a fix. I think it is OK now.
>>>>
>>>> There's still an issue - most of the <pre> blocks now have spurious
>>>> spaces or line-breaks.
>>>> This messes up the layout.
>>>>
>>>> It's particularly noticeable for properties reference 20.22  - the
>>>> 'mode' description
>>>>
>>>> Also the code items on that page have leading and/or trailing spaces
>>>> which look odd.
>>>
>>> That's nothing new. Look at any link. The link will be too wide, which
>>> looks
>>> odd. Same for bold or other emphasized text fragments. That is one
>>> reason,
>>> why I would like to get rid of vsl.
>>>
>>>> I think the change should be reverted for both <source> and <code>.
>>>
>>> That would mean, that we would have to change the documentation, as there
>>> are code/source elements, that have embedded other elements. Those would
>>> not
>>> work any more (and have been the reason for the original change).
>>>
>>> I will have a look at it.
>>>
>>> Most probably the macros would have to be written with less spaces in
>>> between them.
>>
>> That would help, but is going to be tedious.
>>
>> Or we don't allow embedded elements in code and/or source?
>> Are there many occurrences of these?
>>
>> A hack would be to have two versions - the original and the new one
>> that uses runloop.
>
> Have a look at r1785358, I hope it satisfies you (at least for the moment).
> The strange new lines in 20.22 are gone. As a plus, the links are shortened,
> also.
>
> The trick is to put comments at the end of lines, that are not really line
> endings. The comment for velocity seems to be "##".

Thanks, that looks fine.

> Felix
>
>>
>>> Regards,
>>>   Felix
>>>
>>>> The subsequent fix (r1785002) seems OK.
>>>>
>>>>> Thanks for spotting this.
>>>>>    Felix
>>>>>
>>>>>>> Modified:
>>>>>>>        jmeter/trunk/xdocs/stylesheets/site_printable.vsl
>>>>>>>
>>>>>>> Modified: jmeter/trunk/xdocs/stylesheets/site_printable.vsl
>>>>>>> URL:
>>>>>>>
>>>>>>>
>>>>>>> http://svn.apache.org/viewvc/jmeter/trunk/xdocs/stylesheets/site_printable.vsl?rev=1763904&r1=1763903&r2=1763904&view=diff
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>> ==============================================================================
>>>>>>> --- jmeter/trunk/xdocs/stylesheets/site_printable.vsl (original)
>>>>>>> +++ jmeter/trunk/xdocs/stylesheets/site_printable.vsl Sat Oct  8
>>>>>>> 15:26:31
>>>>>>> 2016
>>>>>>> @@ -133,7 +133,7 @@ $value.content
>>>>>>>     #end
>>>>>>>
>>>>>>>     #macro ( code $value)
>>>>>>> -<tt class="code">$escape.getText($value.getText())</tt>
>>>>>>> +<tt class="code">#runloop($value)</tt>
>>>>>>>     #end
>>>>>>>
>>>>>>>     #macro ( source $value)
>>>>>>> @@ -146,7 +146,7 @@ $value.content
>>>>>>>     </tr>
>>>>>>>     <tr>
>>>>>>>     <td bgcolor="#023264" width="1"><img src="/images/void.gif"
>>>>>>> width="1"
>>>>>>> height="1" vspace="0" hspace="0" border="0"/></td>
>>>>>>> -<td
>>>>>>> bgcolor="#ffffff"><pre>$escape.getText($value.getText())</pre></td>
>>>>>>> +<td bgcolor="#ffffff"><pre>#runloop($value)</pre></td>
>>>>>>>     <td bgcolor="#023264" width="1"><img src="/images/void.gif"
>>>>>>> width="1"
>>>>>>> height="1" vspace="0" hspace="0" border="0"/></td>
>>>>>>>     </tr>
>>>>>>>     <tr>
>>>>>>>
>>>>>>>
>