Mailing-List: contact dev-help@jmeter.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@jmeter.apache.org
Received-SPF: pass (athena.apache.org: domain of philippe.mouawad@gmail.com
 designates 209.85.216.178 as permitted sender)
MIME-Version: 1.0
In-Reply-To: 
 <CAH9fUpbEAbeQY4kVm9EodiMXfYfLNyqpZDM438sdLSckZg131g@mail.gmail.com>
References: 
 <CAH9fUpbEAbeQY4kVm9EodiMXfYfLNyqpZDM438sdLSckZg131g@mail.gmail.com>
Date: Sun, 16 Feb 2014 15:06:51 +0100
Message-ID: 
 <CAH9fUpY4qz-PnE8NJVnHw5A=OdfJPzwE2YAbyfngT64ZR8rAGA@mail.gmail.com>
Subject: Re: Some questions about HTTPHC4Impl
From: Philippe Mouawad <philippe.mouawad@gmail.com>
To: "dev@jmeter.apache.org" <dev@jmeter.apache.org>
Content-Type: multipart/alternative; boundary=001a11c11c2e0088c004f2868d4d

--001a11c11c2e0088c004f2868d4d
Content-Type: text/plain; charset=ISO-8859-1

            ((AbstractHttpClient)
httpClient).addResponseInterceptor(METRICS_SAVER); // HACK

Any clarification about this hack ?

I understand METRICS_SAVER saves metrics as another attribute name, but why
as it should be available under  ((HttpConnection)
context.getAttribute(ExecutionContext.HTTP_CONNECTION).getMetrics();
And METRICS_RESETTER resets these metrics.

I suppose the reset is to have metrics per sample but some comments would
be useful to clarify exactly:
- Why we need to reset, is it only to have it per sample ? this can be an
issue as we loose information like number of requests ...
- Why we need to have METRICS_SAVER, was it some due to a temporary bug or
missing feature in HTTPClient 4 at time of writing ?

Regards
Philippe


On Sun, Feb 16, 2014 at 2:48 PM, Philippe Mouawad <
philippe.mouawad@gmail.com> wrote:

> Hello,
> Looking at code of HTTPHC4Impl, I see this:
>
>     private static final String CONTEXT_METRICS = "jmeter_metrics"; //
> TODO hack, to be removed later
>
>
> --
> Cordialement.
> Philippe Mouawad.
>
>
>


-- 
Cordialement.
Philippe Mouawad.

--001a11c11c2e0088c004f2868d4d--