Mailing-List: contact dev-help@jmeter.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@jmeter.apache.org
Received-SPF: pass (athena.apache.org: domain of sebbaz@gmail.com designates
 74.125.82.172 as permitted sender)
MIME-Version: 1.0
In-Reply-To: <51DD5B7C.3070002@apache.org>
References: 
 <CAOGo0VZ3ve+BBYRZX8K8OYrKBXe7Z1ZGrE-4TXOU_qW-3VJGhQ@mail.gmail.com>
	<51DBF9B7.4050104@apache.org>
	<CAOGo0VYwvJUw8pmbr6wMej4fmRDY=YChCAh2Vj2f4k+gaOUAEw@mail.gmail.com>
	<CAOGo0VZMZq7vcY_xu-GY1ynbb9J-obg8u9wVPUAL-WOFno3VgA@mail.gmail.com>
	<51DC170E.5050600@apache.org>
	<CAOGo0VaFf1D0xDfbtOQgmpr3B6qCqpQG9yJGayE_vaHAb90tbw@mail.gmail.com>
	<51DC2A58.2000003@apache.org>
	<CAOGo0Vab5XyDW2Mot6Y7Rp3fVmk96ZJG9eNRxq8_XSrq4R_CgQ@mail.gmail.com>
	<51DD5B7C.3070002@apache.org>
Date: Wed, 10 Jul 2013 16:20:41 +0100
Message-ID: 
 <CAOGo0VackjJqZx6=bXVR-YR+NosRzX5SVfiHqdLPf94Mzpgo8A@mail.gmail.com>
Subject: Re: New from Template silently overwrites files
From: sebb <sebbaz@gmail.com>
To: dev@jmeter.apache.org
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable

On 10 July 2013 14:02, Milamber <milamber@apache.org> wrote:
>
> Le 09/07/2013 22:31, sebb a ecrit :
>
>> OK, done - I hope!
>
>
> Thanks, I made some tests with succes.
>
>
> The templates seems a very good feature to JMeter, bring a lot of new
> opportunities.
>

Yes.

I was initially sceptical, but having seen it in use, I can see it is
useful for getting started.

>
>
>>
>> On 9 July 2013 16:20, Milamber <milamber@apache.org> wrote:
>>>
>>> Le 09/07/2013 14:58, sebb a ecrit :
>>>
>>>> On 9 July 2013 14:58, Milamber <milamber@apache.org> wrote:
>>>>>
>>>>> Le 09/07/2013 13:20, sebb a ecrit :
>>>>>
>>>>>> On 9 July 2013 13:01, sebb <sebbaz@gmail.com> wrote:
>>>>>>>
>>>>>>> On 9 July 2013 12:53, Milamber <milamber@apache.org> wrote:
>>>>>>>>
>>>>>>>> Le 09/07/2013 11:46, sebb a ecrit :
>>>>>>>>
>>>>>>>>> Just noticed that the "New From Template" feature creates a file =
in
>>>>>>>>> the current working directory.
>>>>>>>>>
>>>>>>>>> It silently overwrites any file with the same name as the templat=
e.
>>>>>>>>>
>>>>>>>>> It would be easy to lose a valuable test plan.
>>>>>>>>>
>>>>>>>>> I'm not sure why the code does not just load the content from the
>>>>>>>>> template, and leave to the user to save the test plan where they
>>>>>>>>> wish.
>>>>>>>>
>>>>>>>>
>>>>>>>> +1, I would be better to make like "merge" (or use the merge
>>>>>>>> functionalty)
>>>>>>>> to open the template.
>>>>>>>>
>>>>>>> Yes - would need to clear any existing plan first though.
>>>>>>>
>>>>>> Just occurs to me that one might want to use templates for partial
>>>>>> test
>>>>>> plans?
>>>>>
>>>>>
>>>>> Yes, I think it's natural to use the template as partial test plans
>>>>> (like
>>>>> "add my favorite listener")
>>>>>
>>>>>
>>>>>> If so, then it would be useful not to clear the existing plan first.
>>>>>
>>>>>
>>>>> Yes. Perhaps a checkbox "Replace (and remove) current test plan" or
>>>>> "Merge
>>>>> with current test plans".
>>>>>
>>>> If the template is a comple test plan, I'm not sure it makes sense to
>>>> Merge it.
>>>> Likewise snippets must be Merged.
>>>>
>>>> Maybe the "Create" button at the bottom needs to change according to
>>>> the template type - either "Create" or "Merge" ?
>>>
>>>
>>> +1 seems the good deal.
>>>
>>>
>>>>>> Maybe the templates.xml file could include a flag to say whether the
>>>>>> template was a complete test plan or just a snippet?
>>>>>> That would allow the dialog box to easily distinguish the two types.
>>>>>
>>>>>
>>>>> +1
>>>>>
>>>>>
>>>>>> The Menu item would need to be changed to "Templates..."
>>>>>
>>>>>
>>>>> Philippe has already do this for french translation ("Mod=E8les..." n=
ot
>>>>> "Nouveau depuis mod=E8les")
>>>>> I agree "Templates..." seems better.
>>>>>
>>>>>
>>>>>>>>> After all, unless they change the template, they can just refetch
>>>>>>>>> it.
>>>>>>>>>
>>>>>>>>> Thoughts?
>>>>>>>>>
>