Mailing-List: contact user-help@jclouds.apache.org; run by ezmlm
Precedence: bulk
Reply-To: user@jclouds.apache.org
MIME-Version: 1.0
From: Bram Pouwelse <bram@pouwelse.com>
Date: Fri, 10 Jun 2016 12:45:41 +0000
Message-ID: <CAKvr0DqtMzbdDF=tjCA92Ft_K3jub-BrQv8N6o9o=u6DM7XpTg@mail.gmail.com>
Subject: BlobStore#clearContainer never returns after closing BlobStoreContext
To: user@jclouds.apache.org
Content-Type: multipart/alternative; boundary=001a11412c343579090534ebebd7
archived-at: Fri, 10 Jun 2016 12:45:56 -0000

--001a11412c343579090534ebebd7
Content-Type: text/plain; charset=UTF-8

Hi,

I'm running into some never ending integration tests in my prohect after
upgrading jcouds to 1.9.2, this seems to be caused by calling
BlobStore#clearContainer after the BlobStoreContext has been closed. I've
attached a patch to demonstrate this issue using the
org.jclouds.blobstore.integration.TransientServiceIntegrationTest at the
end of this mail.

After figuring out the root cause of my problem I did some more tests and I
don't really get what the close method is supposed to do, If I try the same
using the filesystem provider there is no issue? How is it possible the
BlobStoreContext (and BlobStore instances created from that context) are
still usable after closing the context?

Regards,
Bram

Patch (tested on the 1.9.x branch):

diff --git
a/blobstore/src/test/java/org/jclouds/blobstore/integration/TransientBlobIntegrationTest.java
b/blobstore/src/test/java/org/jclouds/blobstore/integration/TransientBlobIntegrationTest.java
index eeaaf96..e63cef6 100644
---
a/blobstore/src/test/java/org/jclouds/blobstore/integration/TransientBlobIntegrationTest.java
+++
b/blobstore/src/test/java/org/jclouds/blobstore/integration/TransientBlobIntegrationTest.java
@@ -16,6 +16,8 @@
  */
 package org.jclouds.blobstore.integration;

+import org.jclouds.blobstore.BlobStore;
+
 import org.jclouds.blobstore.integration.internal.BaseBlobIntegrationTest;
 import org.testng.annotations.Test;

@@ -24,4 +26,13 @@ public class TransientBlobIntegrationTest extends
BaseBlobIntegrationTest {
    public TransientBlobIntegrationTest() {
       provider = "transient";
    }
+
+   @Test(groups = { "integration"})
+   public void testClearContainerAfterCloseNeverEnds() throws Exception {
+        BlobStore blobStore = view.getBlobStore();
+        blobStore.createContainerInLocation(null, "test");
+        blobStore.putBlob("test",
blobStore.blobBuilder("dummy").payload("test".getBytes()).build());
+    view.close();
+        blobStore.clearContainer("test");
+   }
 }

--001a11412c343579090534ebebd7
Content-Type: text/html; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr">Hi,=C2=A0<div><br></div><div>I&#39;m running into some nev=
er ending integration tests in my prohect after upgrading jcouds to 1.9.2, =
this seems to be caused by calling BlobStore#clearContainer after the BlobS=
toreContext has been closed. I&#39;ve attached a patch to demonstrate this =
issue using the org.jclouds.blobstore.integration.TransientServiceIntegrati=
onTest at the end of this mail.=C2=A0</div><div><br></div><div>After figuri=
ng out the root cause of my problem I did some more tests and I don&#39;t r=
eally get what the close method is supposed to do, If I try the same using =
the filesystem provider there is no issue? How is it possible the BlobStore=
Context (and BlobStore instances created from that context) are still usabl=
e after closing the context?=C2=A0</div><div><br></div><div>Regards,</div><=
div>Bram=C2=A0</div><div><br></div><div>Patch (tested on the 1.9.x branch):=
=C2=A0</div><div><br></div><div><div>diff --git a/blobstore/src/test/java/o=
rg/jclouds/blobstore/integration/TransientBlobIntegrationTest.java b/blobst=
ore/src/test/java/org/jclouds/blobstore/integration/TransientBlobIntegratio=
nTest.java</div><div>index eeaaf96..e63cef6 100644</div><div>--- a/blobstor=
e/src/test/java/org/jclouds/blobstore/integration/TransientBlobIntegrationT=
est.java</div><div>+++ b/blobstore/src/test/java/org/jclouds/blobstore/inte=
gration/TransientBlobIntegrationTest.java</div><div>@@ -16,6 +16,8 @@</div>=
<div>=C2=A0 */</div><div>=C2=A0package org.jclouds.blobstore.integration;</=
div><div><br></div><div>+import org.jclouds.blobstore.BlobStore;</div><div>=
+</div><div>=C2=A0import org.jclouds.blobstore.integration.internal.BaseBlo=
bIntegrationTest;</div><div>=C2=A0import org.testng.annotations.Test;</div>=
<div><br></div><div>@@ -24,4 +26,13 @@ public class TransientBlobIntegratio=
nTest extends BaseBlobIntegrationTest {</div><div>=C2=A0 =C2=A0 public Tran=
sientBlobIntegrationTest() {</div><div>=C2=A0 =C2=A0 =C2=A0 =C2=A0provider =
=3D &quot;transient&quot;;</div><div>=C2=A0 =C2=A0 }</div><div>+</div><div>=
+ =C2=A0 @Test(groups =3D { &quot;integration&quot;})</div><div>+ =C2=A0 pu=
blic void testClearContainerAfterCloseNeverEnds() throws Exception {</div><=
div>+ =C2=A0 =C2=A0 =C2=A0 =C2=A0BlobStore blobStore =3D view.getBlobStore(=
);</div><div>+ =C2=A0 =C2=A0 =C2=A0 =C2=A0blobStore.createContainerInLocati=
on(null, &quot;test&quot;);</div><div>+ =C2=A0 =C2=A0 =C2=A0 =C2=A0blobStor=
e.putBlob(&quot;test&quot;, blobStore.blobBuilder(&quot;dummy&quot;).payloa=
d(&quot;test&quot;.getBytes()).build());</div><div>+ =C2=A0 =C2=A0view.clos=
e();</div><div>+ =C2=A0 =C2=A0 =C2=A0 =C2=A0blobStore.clearContainer(&quot;=
test&quot;);</div><div>+ =C2=A0 }</div><div>=C2=A0}</div></div></div>

--001a11412c343579090534ebebd7--