Return-Path: Delivered-To: apmail-jakarta-jcs-dev-archive@www.apache.org Received: (qmail 17866 invoked from network); 19 Mar 2007 02:30:31 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.2) by minotaur.apache.org with SMTP; 19 Mar 2007 02:30:31 -0000 Received: (qmail 45875 invoked by uid 500); 19 Mar 2007 02:30:38 -0000 Delivered-To: apmail-jakarta-jcs-dev-archive@jakarta.apache.org Received: (qmail 45853 invoked by uid 500); 19 Mar 2007 02:30:38 -0000 Mailing-List: contact jcs-dev-help@jakarta.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: "JCS Developers List" Delivered-To: mailing list jcs-dev@jakarta.apache.org Received: (qmail 45842 invoked by uid 99); 19 Mar 2007 02:30:38 -0000 Received: from herse.apache.org (HELO herse.apache.org) (140.211.11.133) by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 18 Mar 2007 19:30:38 -0700 X-ASF-Spam-Status: No, hits=0.0 required=10.0 tests= X-Spam-Check-By: apache.org Received: from [140.211.11.4] (HELO brutus.apache.org) (140.211.11.4) by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 18 Mar 2007 19:30:30 -0700 Received: from brutus (localhost [127.0.0.1]) by brutus.apache.org (Postfix) with ESMTP id 18139714070 for ; Sun, 18 Mar 2007 19:30:10 -0700 (PDT) Message-ID: <24664288.1174271410095.JavaMail.jira@brutus> Date: Sun, 18 Mar 2007 19:30:10 -0700 (PDT) From: "Aaron Smuts (JIRA)" To: jcs-dev@jakarta.apache.org Subject: [jira] Resolved: (JCS-21) JCS has inconsistent locking of shared data In-Reply-To: <13364313.1174231989274.JavaMail.jira@brutus> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Virus-Checked: Checked by ClamAV on apache.org [ https://issues.apache.org/jira/browse/JCS-21?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aaron Smuts resolved JCS-21. ---------------------------- Resolution: Fixed I applied all the changes except for some private method changes and the optimization method on the indexed disk cache. > JCS has inconsistent locking of shared data > ------------------------------------------- > > Key: JCS-21 > URL: https://issues.apache.org/jira/browse/JCS-21 > Project: JCS > Issue Type: Bug > Affects Versions: jcs-1.2.7.9.2 > Reporter: Michael Stevens > Assigned To: Aaron Smuts > Attachments: locking.diff > > > I've been looking at the trunk JCS code with findbugs (http://findbugs.sf.net/). > One of the things it does is warn when data is inconsistently synchronized - ie when it is sometimes referenced inside a synchronized block and sometimes not. This is not threadsafe - one thread may read old or inconsistent data. > I've patched all the places findbugs complains about by adding appropriate synchronized() blocks. > I suspect this change may require some discussion :) -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. --------------------------------------------------------------------- To unsubscribe, e-mail: jcs-dev-unsubscribe@jakarta.apache.org For additional commands, e-mail: jcs-dev-help@jakarta.apache.org