From oak-issues-return-60934-archive-asf-public=cust-asf.ponee.io@jackrabbit.apache.org Wed Apr 4 13:25:05 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id BD11018064F for ; Wed, 4 Apr 2018 13:25:04 +0200 (CEST) Received: (qmail 88549 invoked by uid 500); 4 Apr 2018 11:25:03 -0000 Mailing-List: contact oak-issues-help@jackrabbit.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: oak-dev@jackrabbit.apache.org Delivered-To: mailing list oak-issues@jackrabbit.apache.org Received: (qmail 88538 invoked by uid 99); 4 Apr 2018 11:25:03 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 04 Apr 2018 11:25:03 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id 5AEFF18038B for ; Wed, 4 Apr 2018 11:25:03 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -109.511 X-Spam-Level: X-Spam-Status: No, score=-109.511 tagged_above=-999 required=6.31 tests=[ENV_AND_HDR_SPF_MATCH=-0.5, KAM_ASCII_DIVIDERS=0.8, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001, T_RP_MATCHES_RCVD=-0.01, USER_IN_DEF_SPF_WL=-7.5, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id BV-Z5MpY71AF for ; Wed, 4 Apr 2018 11:25:01 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id EA4835FD0D for ; Wed, 4 Apr 2018 11:25:00 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 6A1A3E02A9 for ; Wed, 4 Apr 2018 11:25:00 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 2244325614 for ; Wed, 4 Apr 2018 11:25:00 +0000 (UTC) Date: Wed, 4 Apr 2018 11:25:00 +0000 (UTC) From: "Andrei Dulceanu (JIRA)" To: oak-issues@jackrabbit.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (OAK-7384) SegmentNodeStoreStats should expose stats for previous minute per thread group MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/OAK-7384?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16425357#comment-16425357 ] Andrei Dulceanu commented on OAK-7384: -------------------------------------- Thanks for reviewing the initial patch, [~mduerig]! I included the changes you suggested at [0] to track/compare them easier. Could you take another look, please? [0] https://github.com/dulceanu/jackrabbit-oak/tree/issues/OAK-7384 > SegmentNodeStoreStats should expose stats for previous minute per thread group > ------------------------------------------------------------------------------ > > Key: OAK-7384 > URL: https://issues.apache.org/jira/browse/OAK-7384 > Project: Jackrabbit Oak > Issue Type: Improvement > Components: segment-tar > Reporter: Andrei Dulceanu > Assignee: Andrei Dulceanu > Priority: Minor > Labels: tooling > Fix For: 1.9.0, 1.10 > > Attachments: OAK-7384.patch > > > The current "CommitsCountPerWriter" stats exposed by {{SegmentNodeStoreStats}} are hard to follow since there can be too many writers at a time. To improve this, a more coarse-grained version of this metric should be added, in which commits are recorded for groups of threads. The groups should be configurable and represent regexes to be matched by individual thread names. An additional group (i.e. "other") will group all threads not matching any of the defined group regexes. > The current behaviour will be split in two: > * "CommitsCountOtherThreads" will expose a snapshot of threads currently in "other" group > * "CommitsCountPerGroup" will expose an aggregate of commits count per thread group for the previous minute. > Both metrics will be reset each minute. -- This message was sent by Atlassian JIRA (v7.6.3#76005)