Mailing-List: contact oak-issues-help@jackrabbit.apache.org; run by ezmlm
Precedence: bulk
Reply-To: oak-dev@jackrabbit.apache.org
Date: Fri, 2 Jun 2017 14:33:04 +0000 (UTC)
From: "angela (JIRA)" <jira@apache.org>
To: oak-issues@jackrabbit.apache.org
Message-ID: <JIRA.13076874.1496412703000.352362.1496413984103@Atlassian.JIRA>
In-Reply-To: <JIRA.13076874.1496412703000@Atlassian.JIRA>
References: <JIRA.13076874.1496412703000@Atlassian.JIRA> <JIRA.13076874.1496412703705@jira-lw-us.apache.org>
Subject: [jira] [Commented] (OAK-6304) Cyclic dependency between
 oak.spi.query an oak.query.*
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
archived-at: Fri, 02 Jun 2017 14:33:07 -0000


    [ https://issues.apache.org/jira/browse/OAK-6304?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16034788#comment-16034788 ] 

angela commented on OAK-6304:
-----------------------------

another example: {{o.a.j.oak.spi.query.QueryIndex.FulltextQueryIndex}} defines {{NodeAggregator getNodeAggregator();}} but the {{NodeAggregator}} is not part of the query spi but rather defined in the {{o.a.j.oak.plugins.index.aggregate}} package space which additionally contains implementations which i would assume are not intended for public consumption.

> Cyclic dependency between oak.spi.query an oak.query.*
> ------------------------------------------------------
>
>                 Key: OAK-6304
>                 URL: https://issues.apache.org/jira/browse/OAK-6304
>             Project: Jackrabbit Oak
>          Issue Type: Task
>          Components: core, indexing, query
>            Reporter: angela
>
> while working on OAK-6069 i noticed that there exist IMO troublesome dependencies from _o.a.j.oak.spi.query_ back to _o.a.j.oak.query.*_. While i don't know the historical reasons that led to this setup it feels wrong to me that the interfaces and classes in _o.a.j.oak.spi.query_ would have dependencies to packages that from my understanding are supposed to contain implementations.
> while utilities like {{o.a.j.oak.spi.query.Cursors}} may simply have ended up in the wrong bucket and could possibly moved to e.g _o.a.j.query.index_, i couldn't find an easy solution for an interface like  {{o.a.j.oak.spi.query.Filter}} that defines methods returning {{o.a.j.query.fulltext.FullTextExpression}} and {{o.a.j.query.QueryEngineSettings}}, while at the same time being tied to the {{o.a.j.oak.spi.query.QueryIndex}} interface.


--
This message was sent by Atlassian JIRA
(v6.3.15#6346)