Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id BBE5E200C88 for ; Fri, 2 Jun 2017 14:44:08 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id BAB18160BD2; Fri, 2 Jun 2017 12:44:08 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 0D6F7160BD1 for ; Fri, 2 Jun 2017 14:44:07 +0200 (CEST) Received: (qmail 85424 invoked by uid 500); 2 Jun 2017 12:44:07 -0000 Mailing-List: contact oak-issues-help@jackrabbit.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: oak-dev@jackrabbit.apache.org Delivered-To: mailing list oak-issues@jackrabbit.apache.org Received: (qmail 85413 invoked by uid 99); 2 Jun 2017 12:44:07 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd4-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 02 Jun 2017 12:44:07 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org) with ESMTP id 879F0C030C for ; Fri, 2 Jun 2017 12:44:06 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -99.202 X-Spam-Level: X-Spam-Status: No, score=-99.202 tagged_above=-999 required=6.31 tests=[KAM_ASCII_DIVIDERS=0.8, RP_MATCHES_RCVD=-0.001, SPF_PASS=-0.001, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new, port 10024) with ESMTP id Cjtn1sfa8A2Z for ; Fri, 2 Jun 2017 12:44:05 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id 1F4B35FDEE for ; Fri, 2 Jun 2017 12:44:05 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 49296E0051 for ; Fri, 2 Jun 2017 12:44:04 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 0CEE321B55 for ; Fri, 2 Jun 2017 12:44:04 +0000 (UTC) Date: Fri, 2 Jun 2017 12:44:04 +0000 (UTC) From: "angela (JIRA)" To: oak-issues@jackrabbit.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Resolved] (OAK-6301) Make QueryEngineSettingsMBeanImpl an inner class of o.a.j.oak.Oak MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Fri, 02 Jun 2017 12:44:08 -0000 [ https://issues.apache.org/jira/browse/OAK-6301?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] angela resolved OAK-6301. ------------------------- Resolution: Fixed Fix Version/s: 1.7.1 1.8 Committed revision 1797384. > Make QueryEngineSettingsMBeanImpl an inner class of o.a.j.oak.Oak > ----------------------------------------------------------------- > > Key: OAK-6301 > URL: https://issues.apache.org/jira/browse/OAK-6301 > Project: Jackrabbit Oak > Issue Type: Improvement > Components: core, query > Reporter: angela > Assignee: angela > Fix For: 1.8, 1.7.1 > > > looking at the query code base in the light of OAK-6069 i came across {{o.a.j.oak.query.QueryEngineSettingsMBeanImpl}} wondering why we have 2 implementations of the {{QueryEngineSettingsMBean}} interface in the same package. While {{QueryEngineSettings}} is widely used across the oak code base the {{QueryEngineSettingsMBeanImpl}} has a single usage in the {{o.a.j.oak.Oak}} helper class. > [~tmueller] explained me the reason for having this additional implementation (instead of having just a single one). however, i would suggest to make {{QueryEngineSettingsMBeanImpl}} an inner class of the {{Oak}} helper and thus ensure that it's not used mistakenly or causes extra confusion (as it did for me ;-)) -- This message was sent by Atlassian JIRA (v6.3.15#6346)