jackrabbit-oak-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "angela (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (OAK-6304) Cyclic dependency between oak.spi.query an oak.query.*
Date Fri, 02 Jun 2017 14:38:04 GMT

    [ https://issues.apache.org/jira/browse/OAK-6304?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16034795#comment-16034795

angela commented on OAK-6304:

and {{o.a.j.oak.spi.query.PropertyValues}}: while this class doesn't have any dependency to
query altogether it links the _spi.query_ package space to _o.a.j.namepath_, which in turn
depends on _o.a.j.plugins.name_, _o.a.j.plugins.tree_ and _o.a.j.plugins.identifier_ as it
mixes interfaces with concrete implementations.

> Cyclic dependency between oak.spi.query an oak.query.*
> ------------------------------------------------------
>                 Key: OAK-6304
>                 URL: https://issues.apache.org/jira/browse/OAK-6304
>             Project: Jackrabbit Oak
>          Issue Type: Task
>          Components: core, indexing, query
>            Reporter: angela
> while working on OAK-6069 i noticed that there exist IMO troublesome dependencies from
_o.a.j.oak.spi.query_ back to _o.a.j.oak.query.*_. While i don't know the historical reasons
that led to this setup it feels wrong to me that the interfaces and classes in _o.a.j.oak.spi.query_
would have dependencies to packages that from my understanding are supposed to contain implementations.
> while utilities like {{o.a.j.oak.spi.query.Cursors}} may simply have ended up in the
wrong bucket and could possibly moved to e.g _o.a.j.query.index_, i couldn't find an easy
solution for an interface like  {{o.a.j.oak.spi.query.Filter}} that defines methods returning
{{o.a.j.query.fulltext.FullTextExpression}} and {{o.a.j.query.QueryEngineSettings}}, while
at the same time being tied to the {{o.a.j.oak.spi.query.QueryIndex}} interface.

This message was sent by Atlassian JIRA

View raw message