jackrabbit-oak-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "angela (JIRA)" <j...@apache.org>
Subject [jira] [Resolved] (OAK-6301) Make QueryEngineSettingsMBeanImpl an inner class of o.a.j.oak.Oak
Date Fri, 02 Jun 2017 12:44:04 GMT

     [ https://issues.apache.org/jira/browse/OAK-6301?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

angela resolved OAK-6301.
-------------------------
       Resolution: Fixed
    Fix Version/s: 1.7.1
                   1.8

Committed revision 1797384.


> Make QueryEngineSettingsMBeanImpl an inner class of o.a.j.oak.Oak
> -----------------------------------------------------------------
>
>                 Key: OAK-6301
>                 URL: https://issues.apache.org/jira/browse/OAK-6301
>             Project: Jackrabbit Oak
>          Issue Type: Improvement
>          Components: core, query
>            Reporter: angela
>            Assignee: angela
>             Fix For: 1.8, 1.7.1
>
>
> looking at the query code base in the light of OAK-6069 i came across {{o.a.j.oak.query.QueryEngineSettingsMBeanImpl}}
wondering why we have 2 implementations of the {{QueryEngineSettingsMBean}} interface in the
same package. While {{QueryEngineSettings}} is widely used across the oak code base the {{QueryEngineSettingsMBeanImpl}}
has a single usage in the {{o.a.j.oak.Oak}} helper class.
> [~tmueller] explained me the reason for having this additional implementation (instead
of having just a single one). however, i would suggest to make {{QueryEngineSettingsMBeanImpl}}
an inner class of the {{Oak}} helper and thus ensure that it's not used mistakenly or causes
extra confusion (as it did for me ;-))



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Mime
View raw message