jackrabbit-oak-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "angela (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (OAK-6295) Move constants from oak.query.QueryImpl to oak.spi.query.QueryConstants
Date Fri, 02 Jun 2017 09:31:04 GMT

     [ https://issues.apache.org/jira/browse/OAK-6295?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel

angela updated OAK-6295:
    Attachment: OAK-6295.patch

[~tmueller], [~teofili] as mentioned above attached the proposed patch.

> Move constants from oak.query.QueryImpl to oak.spi.query.QueryConstants
> -----------------------------------------------------------------------
>                 Key: OAK-6295
>                 URL: https://issues.apache.org/jira/browse/OAK-6295
>             Project: Jackrabbit Oak
>          Issue Type: Improvement
>          Components: core, query
>            Reporter: angela
>         Attachments: OAK-6295.patch
> in the light of the modularisation effort i had a look at the query code and noticed
that the constants defined on {{QueryImpl}} are needed outside of the scope of the query implementation.
> IMO that indicates that those constants are of broader use and might better be located
at {{oak.spi.query.QueryConstants}}. moving would in fact remove all imports of {{QueryImpl}}
in the _oak-lucene_ module.
> [~tmueller], [~teofili], it will attach a proposed patch for this improvement and would
appreciate if you could review if you are ok with that change.

This message was sent by Atlassian JIRA

View raw message