jackrabbit-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [jackrabbit-filevault] stefanseifert commented on a change in pull request #110: JCRVLT-485 Ignore mandatory protected properties from mix:versionable
Date Mon, 07 Dec 2020 14:52:24 GMT

stefanseifert commented on a change in pull request #110:
URL: https://github.com/apache/jackrabbit-filevault/pull/110#discussion_r537567543



##########
File path: vault-validation/src/main/java/org/apache/jackrabbit/vault/validation/spi/impl/nodetype/JcrNodeTypeMetaDataImpl.java
##########
@@ -89,6 +89,9 @@
 
     private static final Collection<Name> ALLOWED_PROTECTED_PROPERTIES = Arrays.asList(NameConstants.JCR_PRIMARYTYPE,
             NameConstants.JCR_MIXINTYPES);
+    // ignore mandatory protected properties from mix:versionable, they are handled specifically
in filevault (JCRVLT-485)

Review comment:
       yes, i think this makes sense - updated the PR




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



Mime
View raw message