From dev-return-50140-archive-asf-public=cust-asf.ponee.io@jackrabbit.apache.org Wed Jun 5 06:09:06 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id 9CF6918065D for ; Wed, 5 Jun 2019 08:09:05 +0200 (CEST) Received: (qmail 35429 invoked by uid 500); 5 Jun 2019 06:09:01 -0000 Mailing-List: contact dev-help@jackrabbit.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@jackrabbit.apache.org Delivered-To: mailing list dev@jackrabbit.apache.org Received: (qmail 35413 invoked by uid 99); 5 Jun 2019 06:09:01 -0000 Received: from mailrelay1-us-west.apache.org (HELO mailrelay1-us-west.apache.org) (209.188.14.139) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 05 Jun 2019 06:09:01 +0000 Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id AAB2CE2D05 for ; Wed, 5 Jun 2019 06:09:00 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 3AA992459B for ; Wed, 5 Jun 2019 06:09:00 +0000 (UTC) Date: Wed, 5 Jun 2019 06:09:00 +0000 (UTC) From: "Julian Reschke (JIRA)" To: dev@jackrabbit.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Comment Edited] (JCR-4301) get rid of JSR 305 dependency MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/JCR-4301?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16526293#comment-16526293 ] Julian Reschke edited comment on JCR-4301 at 6/5/19 6:08 AM: ------------------------------------------------------------- [^JCR-4301-jackrabbit-projects.diff] is (was?) an attempt to define custom Jackrabbit annotations, preserving the non-qualified class name if the JSR-305 annotations in order to minimize diffs. I tried the customer o.a.j.annotations.CheckForNull annotation, and spotbugs won't use it. See also https://github.com/spotbugs/spotbugs/blob/master/spotbugs/src/main/java/edu/umd/cs/findbugs/ba/NullnessAnnotation.java. So maybe we should stick to the previously agreed upon approach and live with the fact that we'll have to touch lots of code lines. was (Author: reschke): [^JCR-4301-jackrabbit-projects.diff] is (was?) an attempt to define custom Jackrabbit annotations, preserving the non-qualified class name if the JSR-305 annotations in order to minimize diffs. I tried the customer o.a.j.annotations.CheckForNull annotation, and spotbugs won't use it. See alsohttps://github.com/spotbugs/spotbugs/blob/master/spotbugs/src/main/java/edu/umd/cs/findbugs/ba/NullnessAnnotation.java. So maybe we should stick to the previously agreed upon approach and live with the fact that we'll have to touch lots of code lines. > get rid of JSR 305 dependency > ----------------------------- > > Key: JCR-4301 > URL: https://issues.apache.org/jira/browse/JCR-4301 > Project: Jackrabbit Content Repository > Issue Type: Task > Components: jackrabbit-api > Reporter: Julian Reschke > Assignee: Julian Reschke > Priority: Major > Fix For: 2.18, 2.17.4, 2.16.3 > > Attachments: JCR-4301-2.diff, JCR-4301-jackrabbit-projects.diff, JCR-4301.diff, JCR-4301.diff, convert-annotations.sh > > > We should consider getting rid of the JSR 305 dependency (see ). Note that we only used the annotations in a few recently changed APIs. > Further note that we could use spotbugs as replacement for findbugs to detect problems. -- This message was sent by Atlassian JIRA (v7.6.3#76005)