jackrabbit-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Julian Reschke (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (JCR-4387) Incorrect exception message when same-name-sibling is prevented on import
Date Fri, 14 Dec 2018 10:30:00 GMT

    [ https://issues.apache.org/jira/browse/JCR-4387?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16721212#comment-16721212

Julian Reschke commented on JCR-4387:

FWIW, the same code seems to be present in Oak (ImporterImpl.java).

> Incorrect exception message when same-name-sibling is prevented on import
> -------------------------------------------------------------------------
>                 Key: JCR-4387
>                 URL: https://issues.apache.org/jira/browse/JCR-4387
>             Project: Jackrabbit Content Repository
>          Issue Type: Bug
>          Components: jackrabbit-core
>    Affects Versions: 2.16.2
>            Reporter: Jörg von Frantzius
>            Assignee: Julian Reschke
>            Priority: Minor
>              Labels: candidate_jcr_2_14
>             Fix For: 2.18, 2.16.4, 2.17.7
>         Attachments: DocumentViewTest.java, JCR-4387.diff, JCR-4387.diff, SessionImporter.java
> When importing XML for a node with the same name as an existing node, but with different
UUID, an ItemExistsException is thrown, effectively preventing the creation of a same-name
sibling on import.
> Assuming that same-name siblings are supposed to be prevented on import, that's totally
perfect, but the error message of the Exception thrown is wrong and very misleading: "Node
with the same UUID exists", where it should be something like "Node with same *name* exists,
must prevent same-name-sibling".
> [https://github.com/apache/jackrabbit/blob/b23d6734381e49f236c3705820126803555608b5/jackrabbit-core/src/main/java/org/apache/jackrabbit/core/xml/SessionImporter.java#L381]
> As a suggestion, perhaps the code should further check for javax.jcr.nodetype.NodeDefinition#allowsSameNameSiblings
before throwing the exception?

This message was sent by Atlassian JIRA

View raw message