From sanselan-commits-return-179-apmail-incubator-sanselan-commits-archive=incubator.apache.org@incubator.apache.org Sun Jan 18 15:58:34 2009
Return-Path: <sanselan-commits-return-179-apmail-incubator-sanselan-commits-archive=incubator.apache.org@incubator.apache.org>
Delivered-To: apmail-incubator-sanselan-commits-archive@locus.apache.org
Received: (qmail 5172 invoked from network); 18 Jan 2009 15:58:34 -0000
Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.2)
  by minotaur.apache.org with SMTP; 18 Jan 2009 15:58:34 -0000
Received: (qmail 92137 invoked by uid 500); 18 Jan 2009 15:58:34 -0000
Delivered-To: apmail-incubator-sanselan-commits-archive@incubator.apache.org
Received: (qmail 92120 invoked by uid 500); 18 Jan 2009 15:58:34 -0000
Mailing-List: contact sanselan-commits-help@incubator.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:sanselan-commits-help@incubator.apache.org>
List-Unsubscribe: <mailto:sanselan-commits-unsubscribe@incubator.apache.org>
List-Post: <mailto:sanselan-commits@incubator.apache.org>
List-Id: <sanselan-commits.incubator.apache.org>
Reply-To: sanselan-dev@incubator.apache.org
Delivered-To: mailing list sanselan-commits@incubator.apache.org
Received: (qmail 92111 invoked by uid 99); 18 Jan 2009 15:58:34 -0000
Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230)
    by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 18 Jan 2009 07:58:34 -0800
X-ASF-Spam-Status: No, hits=-2000.0 required=10.0
	tests=ALL_TRUSTED
X-Spam-Check-By: apache.org
Received: from [140.211.11.4] (HELO eris.apache.org) (140.211.11.4)
    by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 18 Jan 2009 15:58:26 +0000
Received: by eris.apache.org (Postfix, from userid 65534)
	id 8388423888F1; Sun, 18 Jan 2009 07:58:05 -0800 (PST)
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Subject: svn commit: r735476 - in /incubator/sanselan/trunk: pom.xml
 src/assemble/bin.xml
Date: Sun, 18 Jan 2009 15:58:05 -0000
To: sanselan-commits@incubator.apache.org
From: cmchen@apache.org
X-Mailer: svnmailer-1.0.8
Message-Id: <20090118155805.8388423888F1@eris.apache.org>
X-Virus-Checked: Checked by ClamAV on apache.org

Author: cmchen
Date: Sun Jan 18 07:58:05 2009
New Revision: 735476

URL: http://svn.apache.org/viewvc?rev=735476&view=rev
Log:
Apply "Build Improvements" patch from Niall Pemberton:

"""
I took a look at the propsed 0.96 relelase and have some suggestions to improve the build:
 * Add standard manifest entries to jar
 * Lock down version numbers for maven compiler, surefire and javadoc plugins
 * generate sources jar for the release
 * include the RELEASE-NOTES in the binary distribution
 * include NOTICE/LICENSE files in the javadoc jar
"""

https://issues.apache.org/jira/browse/SANSELAN-15?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel

Modified:
    incubator/sanselan/trunk/pom.xml
    incubator/sanselan/trunk/src/assemble/bin.xml

Modified: incubator/sanselan/trunk/pom.xml
URL: http://svn.apache.org/viewvc/incubator/sanselan/trunk/pom.xml?rev=735476&r1=735475&r2=735476&view=diff
==============================================================================
--- incubator/sanselan/trunk/pom.xml (original)
+++ incubator/sanselan/trunk/pom.xml Sun Jan 18 07:58:05 2009
@@ -85,12 +85,44 @@
           <instructions>
             <Bundle-SymbolicName>${pom.groupId}.${pom.artifactId}</Bundle-SymbolicName>
             <Export-Package>org.apache.sanselan.*</Export-Package>
+            <Specification-Title>${project.name}</Specification-Title>
+            <Specification-Version>${project.version}</Specification-Version>
+            <Specification-Vendor>${project.organization.name}</Specification-Vendor>
+            <Implementation-Title>${project.name}</Implementation-Title>
+            <Implementation-Version>${project.version}</Implementation-Version>
+            <Implementation-Vendor>${project.organization.name}</Implementation-Vendor>
+            <Implementation-Vendor-Id>org.apache</Implementation-Vendor-Id>
           </instructions>
         </configuration>
       </plugin>
       <plugin>
         <groupId>org.apache.maven.plugins</groupId>
-        <artifactId>maven-release-plugin</artifactId>
+        <artifactId>maven-compiler-plugin</artifactId>
+        <version>2.0.2</version>
+        </plugin>
+        <plugin>
+          <groupId>org.apache.maven.plugins</groupId>
+          <artifactId>maven-surefire-plugin</artifactId>
+          <version>2.4.3</version>
+        </plugin>
+        <plugin>
+          <groupId>org.apache.maven.plugins</groupId>
+          <artifactId>maven-javadoc-plugin</artifactId>
+          <version>2.5</version>
+        </plugin>
+        <plugin>
+          <groupId>org.apache.maven.plugins</groupId>
+          <artifactId>maven-source-plugin</artifactId>
+          <version>2.0.4</version>
+        </plugin>
+        <plugin>
+          <groupId>org.apache.maven.plugins</groupId>
+          <artifactId>maven-antrun-plugin</artifactId>
+          <version>1.3</version>
+        </plugin>
+        <plugin>
+          <groupId>org.apache.maven.plugins</groupId>
+          <artifactId>maven-release-plugin</artifactId>
         <configuration>
           <tagBase>https://svn.apache.org/repos/asf/incubator/sanselan/tags</tagBase>
           <useReleaseProfile>false</useReleaseProfile>
@@ -141,6 +173,7 @@
         <includes>
           <include>LICENSE</include>
           <include>NOTICE</include>
+          <include>README.txt</include>
         </includes>
       </resource>
     </resources>
@@ -181,6 +214,47 @@
             </executions>
 	      </plugin>
 
+          <plugin>
+            <!--
+              - Copy LICENSE.txt and NOTICE.txt so that they are included
+              - in the -javadoc jar file for the component.
+              -->
+            <groupId>org.apache.maven.plugins</groupId>
+            <artifactId>maven-antrun-plugin</artifactId>
+            <executions>
+              <execution>
+                <id>javadoc.resources</id>
+                <phase>generate-sources</phase>
+                <goals>
+                  <goal>run</goal>
+                </goals>
+                <configuration>
+                  <tasks>
+                    <copy todir="${project.build.directory}/apidocs/META-INF">
+                      <fileset dir="${basedir}">
+                        <include name="LICENSE" />
+                        <include name="NOTICE" />
+                      </fileset>
+                    </copy>
+                  </tasks>
+                </configuration>
+              </execution>
+            </executions>
+          </plugin>
+          <plugin>
+            <groupId>org.apache.maven.plugins</groupId>
+            <artifactId>maven-source-plugin</artifactId>
+            <executions>
+              <execution>
+                <id>create-source-jar</id>
+                <phase>package</phase>
+                <goals>
+                  <goal>jar</goal>
+                </goals>
+              </execution>
+            </executions>
+          </plugin>
+          
           <!-- The release artifacts -->
           <plugin>
             <groupId>org.apache.maven.plugins</groupId>

Modified: incubator/sanselan/trunk/src/assemble/bin.xml
URL: http://svn.apache.org/viewvc/incubator/sanselan/trunk/src/assemble/bin.xml?rev=735476&r1=735475&r2=735476&view=diff
==============================================================================
--- incubator/sanselan/trunk/src/assemble/bin.xml (original)
+++ incubator/sanselan/trunk/src/assemble/bin.xml Sun Jan 18 07:58:05 2009
@@ -31,6 +31,7 @@
         <include>LICENSE*</include>
         <include>KEYS*</include>
         <include>NOTICE*</include>
+        <include>RELEASE_NOTES*</include>
       </includes>
     </fileSet>
     <fileSet>