From issues-return-120547-archive-asf-public=cust-asf.ponee.io@ignite.apache.org Thu Jun 3 13:30:02 2021 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mxout1-ec2-va.apache.org (mxout1-ec2-va.apache.org [3.227.148.255]) by mx-eu-01.ponee.io (Postfix) with ESMTPS id AB477180643 for ; Thu, 3 Jun 2021 15:30:02 +0200 (CEST) Received: from mail.apache.org (mailroute1-lw-us.apache.org [207.244.88.153]) by mxout1-ec2-va.apache.org (ASF Mail Server at mxout1-ec2-va.apache.org) with SMTP id E0EAA3EB7D for ; Thu, 3 Jun 2021 13:30:01 +0000 (UTC) Received: (qmail 85197 invoked by uid 500); 3 Jun 2021 13:30:01 -0000 Mailing-List: contact issues-help@ignite.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@ignite.apache.org Delivered-To: mailing list issues@ignite.apache.org Received: (qmail 85188 invoked by uid 99); 3 Jun 2021 13:30:01 -0000 Received: from ec2-52-204-25-47.compute-1.amazonaws.com (HELO mailrelay1-ec2-va.apache.org) (52.204.25.47) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 03 Jun 2021 13:30:01 +0000 Received: from jira2-he-de.apache.org (jira2-he-de.apache.org [168.119.33.54]) by mailrelay1-ec2-va.apache.org (ASF Mail Server at mailrelay1-ec2-va.apache.org) with ESMTPS id 7FA693E97A for ; Thu, 3 Jun 2021 13:30:01 +0000 (UTC) Received: from jira2-he-de.apache.org (localhost.localdomain [127.0.0.1]) by jira2-he-de.apache.org (ASF Mail Server at jira2-he-de.apache.org) with ESMTP id 5AB65C80940 for ; Thu, 3 Jun 2021 13:30:00 +0000 (UTC) Date: Thu, 3 Jun 2021 13:30:00 +0000 (UTC) From: "Ivan Bessonov (Jira)" To: issues@ignite.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Updated] (IGNITE-14800) Add technical ability to differentiate between create and update in configuration MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/IGNITE-14800?page=3Dcom.atlass= ian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ivan Bessonov updated IGNITE-14800: ----------------------------------- Reviewer: Sergey Chugunov > Add technical ability to differentiate between create and update in confi= guration > -------------------------------------------------------------------------= -------- > > Key: IGNITE-14800 > URL: https://issues.apache.org/jira/browse/IGNITE-14800 > Project: Ignite > Issue Type: Sub-task > Affects Versions: 3.0.0-alpha2 > Reporter: Ivan Bessonov > Assignee: Ivan Bessonov > Priority: Major > Labels: ignite-3 > Fix For: 3.0.0-alpha3 > > Time Spent: 10m > Remaining Estimate: 0h > > {{org.apache.ignite.configuration.internal.DynamicConfiguration#change}} = method (and its variants in other classes) has a substantial disadvantage -= it doesn't allow you to read current configuration in lambdas to decide a = new value for some other configurations. > Why is this the way it is? For simplicity of implementation, we immediate= ly convert it to {{InnerNode}} and only then pass into configuration change= r. This means that we will apply the same exact tree on every retry iterati= on. > This is bad during concurrent resources creation, if you create 2 resourc= es with the same name, then one of changes will be create and the other one= is update. There is no way to tell what will happen until it is already ha= ppened. Such behavior is not convenient if you create SQL indexes or tables= , for example, CREATE should not be silently converted to ALTER. > Other reason why it's bad - it complicates concurrent array fields update= s. Makes it nearly impossible. > What should we do to fix it? > * CHANGE interfaces should extend VIEW interfaces. Lambda parameters sho= uld be available for read and provide configuration snapshot that's current= ly being updated; > * changing lambda should be applied on every retry. Only then we could g= uarantee that provided configuration snapshots are valid; > * consider using the same procedure for arbitrary configuration sources.= This will save us some code and will be handy in https://issues.apache.org= /jira/browse/IGNITE-14645=C2=A0implementation. -- This message was sent by Atlassian Jira (v8.3.4#803005)