From dev-return-4302-archive-asf-public=cust-asf.ponee.io@hudi.apache.org Tue Aug 17 21:56:51 2021 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mxout1-ec2-va.apache.org (mxout1-ec2-va.apache.org [3.227.148.255]) by mx-eu-01.ponee.io (Postfix) with ESMTPS id 08C43180181 for ; Tue, 17 Aug 2021 23:56:51 +0200 (CEST) Received: from mail.apache.org (mailroute1-lw-us.apache.org [207.244.88.153]) by mxout1-ec2-va.apache.org (ASF Mail Server at mxout1-ec2-va.apache.org) with SMTP id 199DB3FF1D for ; Tue, 17 Aug 2021 21:56:50 +0000 (UTC) Received: (qmail 49089 invoked by uid 500); 17 Aug 2021 21:56:49 -0000 Mailing-List: contact dev-help@hudi.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@hudi.apache.org Delivered-To: mailing list dev@hudi.apache.org Received: (qmail 49077 invoked by uid 99); 17 Aug 2021 21:56:49 -0000 Received: from mailrelay1-he-de.apache.org (HELO mailrelay1-he-de.apache.org) (116.203.21.61) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 17 Aug 2021 21:56:49 +0000 Received: from mail-lj1-f171.google.com (mail-lj1-f171.google.com [209.85.208.171]) by mailrelay1-he-de.apache.org (ASF Mail Server at mailrelay1-he-de.apache.org) with ESMTPSA id 9513E3E8A5 for ; Tue, 17 Aug 2021 21:56:48 +0000 (UTC) Received: by mail-lj1-f171.google.com with SMTP id c12so1256838ljr.5 for ; Tue, 17 Aug 2021 14:56:48 -0700 (PDT) X-Gm-Message-State: AOAM5315oTPVC2LR0sIZqfi3l4uBeHjJDbG3NcnE3s42uImnt2DeFrQS b8Awocd8hKfeFM7fF/4DwkPJ6A9HayNnpeym3FA= X-Google-Smtp-Source: ABdhPJxzrHt3qIwJk8gGCAO9bdfFrsfdNUbh0oG5WpaZSVxheuteqENGJ0GbDlu6VUsiU4pOuZ1nvED/buqpxvB/Kcg= X-Received: by 2002:a2e:9852:: with SMTP id e18mr4908839ljj.173.1629237407996; Tue, 17 Aug 2021 14:56:47 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Vinoth Chandar Date: Tue, 17 Aug 2021 14:56:36 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [VOTE] Release 0.9.0, release candidate #1 To: dev Content-Type: multipart/alternative; boundary="000000000000f55f7405c9c864b5" --000000000000f55f7405c9c864b5 Content-Type: text/plain; charset="UTF-8" Hi, This is another issue that needs to be addressed I think. Checking for binary files in source release There were non-text files in source release. Please check below ./hudi-flink/src/test/resources/test_source_5.data: application/csv; charset=us-ascii Thanks Vinoth On Tue, Aug 17, 2021 at 7:48 AM Vinoth Chandar wrote: > -1 (binding) > > An issue was surfaced yesterday, that affects the re-definition of some > configs in HoodieWriteConfig e.g TABLE_NAME, AVRO_SCHEMA, > AVRO_SCHEMA_VALIDATE > which unfortunately do not have the _PROP suffix added. These are now > re-defining as ConfigProperty members now and jobs using them directly (we > have such usages > even in our quickstart) will have to break upon upgrading to this release. > While, its a bit of a step back to have to rename these to something else, > it might make sense > to keep all such members without _PROP suffix as string and make the new > members TABLE_NAME_CFG etc, to avoid upgrade pain. > > I am also testing the RC for other issues, will update the thread again > with findings. > > Thanks > Vinoth > > On Sun, Aug 15, 2021 at 6:05 PM Raymond Xu > wrote: > >> Ok the Azure CI passed with the patch so the missing test coverage is >> proved not an issue >> >> https://dev.azure.com/apache-hudi-ci-org/apache-hudi-ci/_build/results?buildId=1770&view=results >> >> reverse my -1 to +1 >> >> On Sun, Aug 15, 2021 at 5:10 PM Raymond Xu >> wrote: >> >> > Hey Udit, sorry I'm -1 due to a misconfigured test resulting in some >> test >> > cases getting skipped. The patch was merged to master. >> > https://github.com/apache/hudi/pull/3476/files >> > >> > Created a hotfix PR to the release branch. >> > https://github.com/apache/hudi/pull/3480/files >> > >> > >> > On Sun, Aug 15, 2021 at 4:22 PM Udit Mehrotra >> wrote: >> > >> >> Hi everyone, >> >> >> >> Please review and vote on the release candidate #1 for the version >> 0.9.0, >> >> as follows: >> >> >> >> [ ] +1, Approve the release >> >> >> >> [ ] -1, Do not approve the release (please provide specific comments) >> >> >> >> The complete staging area is available for your review, which includes: >> >> >> >> * JIRA release notes [1], >> >> >> >> * the official Apache source release and binary convenience releases >> to be >> >> deployed to dist.apache.org [2], which are signed with the key with >> >> fingerprint 44A484600E48193A74F97447C47E66F8386204DF [3], >> >> >> >> * all artifacts to be deployed to the Maven Central Repository [4], >> >> >> >> * source code tag "release-0.9.0-rc1" [5], >> >> >> >> The vote will be open for at least 72 hours. It is adopted by majority >> >> approval, with at least 3 PMC affirmative votes. >> >> >> >> Thanks, >> >> >> >> Release Manager >> >> >> >> [1] >> >> >> >> >> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12322822&version=12350027 >> >> >> >> [2] https://dist.apache.org/repos/dist/dev/hudi/hudi-0.9.0-rc1/ >> >> >> >> [3] https://dist.apache.org/repos/dist/dev/hudi/KEYS >> >> >> >> [4] >> >> >> >> >> https://repository.apache.org/content/repositories/orgapachehudi-1042/org/apache/hudi/ >> >> >> >> [5] https://github.com/apache/hudi/tree/release-0.9.0-rc1 >> >> >> > >> > --000000000000f55f7405c9c864b5--