From dev-return-4323-archive-asf-public=cust-asf.ponee.io@hudi.apache.org Tue Aug 24 15:19:45 2021 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mxout1-ec2-va.apache.org (mxout1-ec2-va.apache.org [3.227.148.255]) by mx-eu-01.ponee.io (Postfix) with ESMTPS id 21AFF180626 for ; Tue, 24 Aug 2021 17:19:45 +0200 (CEST) Received: from mail.apache.org (mailroute1-lw-us.apache.org [207.244.88.153]) by mxout1-ec2-va.apache.org (ASF Mail Server at mxout1-ec2-va.apache.org) with SMTP id B49EA4057E for ; Tue, 24 Aug 2021 15:19:08 +0000 (UTC) Received: (qmail 52629 invoked by uid 500); 24 Aug 2021 15:19:08 -0000 Mailing-List: contact dev-help@hudi.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@hudi.apache.org Delivered-To: mailing list dev@hudi.apache.org Received: (qmail 52613 invoked by uid 99); 24 Aug 2021 15:19:08 -0000 Received: from spamproc1-he-fi.apache.org (HELO spamproc1-he-fi.apache.org) (95.217.134.168) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 24 Aug 2021 15:19:08 +0000 Received: from localhost (localhost [127.0.0.1]) by spamproc1-he-fi.apache.org (ASF Mail Server at spamproc1-he-fi.apache.org) with ESMTP id 7534DBFA49 for ; Tue, 24 Aug 2021 15:19:07 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamproc1-he-fi.apache.org X-Spam-Flag: NO X-Spam-Score: 0.05 X-Spam-Level: X-Spam-Status: No, score=0.05 tagged_above=-999 required=6.31 tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_ENVFROM_END_DIGIT=0.25, MIME_QP_LONG_LINE=0.001, SPF_PASS=-0.001] autolearn=disabled Authentication-Results: spamproc1-he-fi.apache.org (amavisd-new); dkim=pass (2048-bit key) header.d=gmail.com Received: from mx1-he-de.apache.org ([116.203.227.195]) by localhost (spamproc1-he-fi.apache.org [95.217.134.168]) (amavisd-new, port 10024) with ESMTP id HLAkT2Ry0xJo for ; Tue, 24 Aug 2021 15:19:04 +0000 (UTC) Received-SPF: Pass (mailfrom) identity=mailfrom; client-ip=2607:f8b0:4864:20::1035; helo=mail-pj1-x1035.google.com; envelope-from=n3.nash29@gmail.com; receiver= Received: from mail-pj1-x1035.google.com (mail-pj1-x1035.google.com [IPv6:2607:f8b0:4864:20::1035]) by mx1-he-de.apache.org (ASF Mail Server at mx1-he-de.apache.org) with ESMTPS id B6D217DD21 for ; Tue, 24 Aug 2021 15:19:03 +0000 (UTC) Received: by mail-pj1-x1035.google.com with SMTP id j1so14456886pjv.3 for ; Tue, 24 Aug 2021 08:19:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=content-transfer-encoding:from:mime-version:subject:date:message-id :references:in-reply-to:to; bh=FOccLGY7ZyODLkRHuCdgmI3JSamhJ4iNbbixHEg9BXA=; b=XxLvvIuGxJ9KJH5fB/YGzYdN5Ka2Wn27SUwzmlrvmh1TNgEP48eQZSWuir5cuXE2oZ 5uqPMwvDJePoRI93TB4XNeHIHl+VzlMgI4rPTRr7D0u11NfexQ02tflp5RW5CZzpmspj 5p0l2gQ2EDSxKW45bx4fwh0UrvV+YC/IAdjhcqJ/Kxsitrz1t9btySpx9/tzxZJnptVh ybokx0MjdJ3YJvyapEdTkCdkXlaYSkoEdHPPHzzwLahi9eTUT7yb0mNoIuIN00886Lbg jE7P7Lav/dUqGI3HAa0pNjy2gn/ZPbMEd33IKWcOgOvA5KDVKmFckcO24IEPhM2cfYpt KfVQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:content-transfer-encoding:from:mime-version :subject:date:message-id:references:in-reply-to:to; bh=FOccLGY7ZyODLkRHuCdgmI3JSamhJ4iNbbixHEg9BXA=; b=W3JgfupmetOhXW6IFif+YAk1OH7fUqYT/koPONQmX5PaaCD+fXvD9Ka6f4XcPzXIEB BlKZqxIYd64UFFhFHtRZgNs7zB745EsagL+sAm3IhWYOZOSAFXBiSXtvmhTCF5JXFkJs qctXPfXvepm+Tc0F0ooRB4su96233se7RJQRre0AxKUUgeWcJBuEsXwr0/bqZo9gDgMp R2GXk3IZlf0hDXwcYHgLwvGLrU8unvRl6OJ3wlv2mvVWFXmI6UA2TyxbfyfjSGJLcY1P 1y0sytdByBqKn3aG19l5RF7DqbmhoZy7oq68LFg5DBHEDp2bucNcKj3vx9aPiEexRyqF YANg== X-Gm-Message-State: AOAM531dpw2cAPnVyu+1ls5+v04RMim0Z+sa9074VQfk37Bl7vCIwWoG WWv4OntWyXGAc9440EbAM0yutooWTly5Tg== X-Google-Smtp-Source: ABdhPJxpOVINXKgXRPvypKmNP2RyzO8Gy0tTYiabAejmXD4a6qmXEVd9hHv7wk3MMUax/j2ybAOujw== X-Received: by 2002:a17:90a:aa0a:: with SMTP id k10mr4951075pjq.99.1629818341591; Tue, 24 Aug 2021 08:19:01 -0700 (PDT) Received: from smtpclient.apple (136-25-20-70.cab.webpass.net. [136.25.20.70]) by smtp.gmail.com with ESMTPSA id g3sm23256176pgj.66.2021.08.24.08.19.00 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 24 Aug 2021 08:19:00 -0700 (PDT) Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable From: Nishith Mime-Version: 1.0 (1.0) Subject: Re: [VOTE] Release 0.9.0, release candidate #2 Date: Tue, 24 Aug 2021 08:18:59 -0700 Message-Id: <9171F2D3-E06A-436D-839C-AEAEC78E5AAD@gmail.com> References: <1686963919.39189.1629774488352@mail.yahoo.com> In-Reply-To: <1686963919.39189.1629774488352@mail.yahoo.com> To: dev@hudi.apache.org X-Mailer: iPhone Mail (18G82) +1 (binding) > On Aug 23, 2021, at 8:08 PM, Balaji Varadarajan wrote: >=20 > =EF=BB=BF +1 (binding)=20 > $ ./release/validate_staged_release.sh --release=3D${RC_VERSION} --rc_num=3D= 2 > ...Downloading from svn co https://dist.apache.org/repos/dist//dev/hudiVal= idating hudi-0.9.0-rc2 with release type "dev"Checking Checksum of Source Re= lease Checksum Check of Source Release - [OK] > % Total % Received % Xferd Average Speed Time Time Time Cu= rrent Dload Upload Total Spent Left = Speed100 42380 100 42380 0 0 98k 0 --:--:-- --:--:-- --:--:= -- 98kChecking Signature Signature Check - [OK] > Checking for binary files in source release No Binary Files in Source Rele= ase? - [OK] > Checking for DISCLAIMER DISCLAIMER file exists ? [OK] > Checking for LICENSE and NOTICE License file exists ? [OK] Notice file exi= sts ? [OK] > Performing custom Licensing Check Licensing Check Passed [OK] > Running RAT Check RAT Check Passed [OK] > Balaji.V >=20 > On Monday, August 23, 2021, 03:34:37 PM PDT, Bhavani Sudha wrote: =20 >=20 > +1 (binding) >=20 >> On Mon, Aug 23, 2021 at 3:23 PM Sivabalan wrote: >>=20 >> +1 (binding) >>=20 >> 1. Release validation succeeded >> 2. Ran quick start for two variants (spark2, scala11 and spark3, scala12)= >> for all operations. >> 3. Ran docker demo and verified all 3 query engines (spark sql, hive, >> presto) and 3 query types(snapshot, read optimized, incremental) across t= wo >> tables. >>=20 >> ./release/validate_staged_release.sh --release=3D0.9.0 --rc_num=3D2 >> /tmp/validation_scratch_dir_001 >> ~/Documents/personal/projects/a_hudi/hudi/scripts >> local dir local_svn_dir >> Downloading from svn co https://dist.apache.org/repos/dist//dev/hudi >> Validating hudi-0.9.0-rc2 with release type "dev" >> Checking Checksum of Source Release >> Checksum Check of Source Release - [OK] >>=20 >> % Total % Received % Xferd Average Speed Time Time Time >> Current >> Dload Upload Total Spent Left >> Speed >> 100 42380 100 42380 0 0 156k 0 --:--:-- --:--:-- --:--:-- >> 156k >> Checking Signature >> Signature Check - [OK] >>=20 >> Checking for binary files in source release >> No Binary Files in Source Release? - [OK] >>=20 >> Checking for DISCLAIMER >> DISCLAIMER file exists ? [OK] >>=20 >> Checking for LICENSE and NOTICE >> License file exists ? [OK] >> Notice file exists ? [OK] >>=20 >> Performing custom Licensing Check >> Licensing Check Passed [OK] >>=20 >> Running RAT Check >> RAT Check Passed [OK] >>=20 >>=20 >>=20 >>=20 >>=20 >>=20 >>=20 >>> On Sun, Aug 22, 2021 at 9:09 PM Vinoth Chandar wrote= : >>>=20 >>> +1 (binding) >>>=20 >>> RC check [1] passed >>>=20 >>> [1] >> https://gist.github.com/vinothchandar/68b34f3051e41752ebffd6a3edeb042b >>>=20 >>>=20 >>>> On Sun, Aug 22, 2021 at 1:28 PM Sivabalan wrote: >>>=20 >>>> We can keep the specific discussion out of this voting thread. Have >>> started >>>> a new thread here >>>> < >>>>=20 >>>=20 >> https://lists.apache.org/thread.html/r3bae7622904b04c7d1fb2ddaf5226e37166= d5fbb1721f403b1b04545%40%3Cdev.hudi.apache.org%3E >>>>>=20 >>>> to >>>> continue this discussion. We can keep this thread just for voting. >>> Thanks. >>>>=20 >>>> On Sun, Aug 22, 2021 at 2:13 AM Danny Chan >> wrote: >>>>=20 >>>>> It's not a surprise that 0.9 has a longer release process, the Spark >>> SQL >>>>> was added and many promotions from the Flink engine. We need more >>>> patience >>>>> for this release IMO. >>>>>=20 >>>>> Having another minor release like 0.9.1 is a solution but not a good >>> one, >>>>> people have much more promise to the major release and it carries >>>>> many expectations. If people report the problems during the release >>>>> process, just accept it if it is not a big PR/fix, and there are >> only a >>>> few >>>>> ones up to now. I would not take too much time. >>>>>=20 >>>>> I know that it has been about 4 months since the last release, but >>> people >>>>> want a complete release version not a defective one. >>>>>=20 >>>>> Best, >>>>> Danny >>>>>=20 >>>>> Sivabalan =E4=BA=8E2021=E5=B9=B48=E6=9C=8822=E6=97= =A5=E5=91=A8=E6=97=A5 =E4=B8=8A=E5=8D=8811:50=E5=86=99=E9=81=93=EF=BC=9A >>>>>=20 >>>>>> I would like to share my thoughts on the release process in >> general. >>> I >>>>> will >>>>>> read more about what exactly qualifies for -1 and will look into >> what >>>>> Peng >>>>>> and Danny has put up. But some thoughts on the release in general. >>>>>>=20 >>>>>> Every release process is very tedious and time consuming and RM >> does >>>> put >>>>> in >>>>>> non-trivial amount of work in getting the release out. To make the >>>>> process >>>>>> smooth, RM started an email thread by Aug 3, calling for any >> release >>>>>> blockers. Would like to understand, if these were surfaced in that >>>>> thread? >>>>>> What I am afraid of is, we might keep delaying our release by >> adding >>>> more >>>>>> patches/bug fixes with every candidate. For instance, if we >> consider >>>>> these >>>>>> and RM works on RC3 and puts up a vote in 5 days and what if >> someone >>>> else >>>>>> wants to add a couple of more fixes or improvements to the release? >>> If >>>>> it's >>>>>> a very serious bug that one cannot do basic operations like >>>> insert/upsert >>>>>> in any of the engines or some serious regression, yeah we can >>>> definitely >>>>>> block the release. But if there are corner case bugs, or any >>>> improvements >>>>>> in general, we can always have another release immediately >> following >>>>> this. >>>>>> This is my humble opinion having gone through the release process >>>> myself >>>>> in >>>>>> the past and have helped others in doing the release in Hudi. It's >>> been >>>>>> more than 4 months we have had a release. Would be good for us to >> be >>>>>> mindful of that as well. Maybe this is common in other projects, >> but >>> I >>>> am >>>>>> not aware of that. Please enlighten me if you have experience with >>>> other >>>>>> projects. >>>>>>=20 >>>>>> I would like to hear from other PMCs and experts who are more >>>>>> knowledgeable about the release process. >>>>>> And if anyone has any suggestions on improving the release process >> in >>>>>> general (if we can seal the patches that go into a release upfront, >>>>> etc), I >>>>>> am all ears to that as well. >>>>>>=20 >>>>>>=20 >>>>>> On Sat, Aug 21, 2021 at 10:41 PM Danny Chan >>>>> wrote: >>>>>>=20 >>>>>>> I have fired a cherry-pick PR: >>>>> https://github.com/apache/hudi/pull/3519 >>>>>>>=20 >>>>>>> Best, >>>>>>> Danny >>>>>>>=20 >>>>>>> Danny Chan =E4=BA=8E2021=E5=B9=B48=E6=9C=8822= =E6=97=A5=E5=91=A8=E6=97=A5 =E4=B8=8A=E5=8D=889:07=E5=86=99=E9=81=93=EF=BC=9A= >>>>>>>=20 >>>>>>>> I'm sorry I would also vote -1. >>>>>>>>=20 >>>>>>>> HUDI-2316 >>>>>>>> HUDI-2340 >>>>>>>> HUDI-2342 >>>>>>>>=20 >>>>>>>> are all important improvements for Flink and we hope they can >> be >>>>>>>> cherry picked to release 0.9. >>>>>>>>=20 >>>>>>>> Best, >>>>>>>> Danny >>>>>>>>=20 >>>>>>>> Udit Mehrotra =E4=BA=8E2021=E5=B9=B48=E6=9C=882= 1=E6=97=A5=E5=91=A8=E5=85=AD =E4=B8=8A=E5=8D=887:13=E5=86=99=E9=81=93=EF=BC=9A= >>>>>>>>=20 >>>>>>>>> Hi everyone, >>>>>>>>>=20 >>>>>>>>> Please review and vote on the release candidate #2 for the >>> version >>>>>>> 0.9.0, >>>>>>>>> as follows: >>>>>>>>>=20 >>>>>>>>> [ ] +1, Approve the release >>>>>>>>>=20 >>>>>>>>> [ ] -1, Do not approve the release (please provide specific >>>>> comments) >>>>>>>>>=20 >>>>>>>>> The complete staging area is available for your review, which >>>>>> includes: >>>>>>>>>=20 >>>>>>>>> * JIRA release notes [1], >>>>>>>>>=20 >>>>>>>>> * the official Apache source release and binary convenience >>>> releases >>>>>> to >>>>>>> be >>>>>>>>> deployed to dist.apache.org [2], which are signed with the >> key >>>> with >>>>>>>>> fingerprint 44A484600E48193A74F97447C47E66F8386204DF [3], >>>>>>>>>=20 >>>>>>>>> * all artifacts to be deployed to the Maven Central Repository >>>> [4], >>>>>>>>>=20 >>>>>>>>> * source code tag "release-0.9.0-rc2" [5], >>>>>>>>>=20 >>>>>>>>> The vote will be open for at least 72 hours. It is adopted by >>>>> majority >>>>>>>>> approval, with at least 3 PMC affirmative votes. >>>>>>>>>=20 >>>>>>>>> Thanks, >>>>>>>>>=20 >>>>>>>>> Release Manager >>>>>>>>>=20 >>>>>>>>> [1] >>>>>>>>>=20 >>>>>>>>>=20 >>>>>>>=20 >>>>>>=20 >>>>>=20 >>>>=20 >>>=20 >> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=3D123228= 22&version=3D12350027 >>>>>>>>>=20 >>>>>>>>> [2] >> https://dist.apache.org/repos/dist/dev/hudi/hudi-0.9.0-rc2/ >>>>>>>>>=20 >>>>>>>>> [3] https://dist.apache.org/repos/dist/dev/hudi/KEYS >>>>>>>>>=20 >>>>>>>>> [4] >>>>>>>>>=20 >>>>>>=20 >>> https://repository.apache.org/content/repositories/orgapachehudi-1043/ >>>>>>>>>=20 >>>>>>>>> < >>>>>>>>>=20 >>>>>>>=20 >>>>>>=20 >>>>>=20 >>>>=20 >>>=20 >> https://repository.apache.org/content/repositories/orgapachehudi-1042/org= /apache/hudi/ >>>>>>>>>> [5] >>>>>>>>> https://github.com/apache/hudi/tree/release-0.9.0-rc2 >>>>>>>>>=20 >>>>>>>>=20 >>>>>>>=20 >>>>>>=20 >>>>>>=20 >>>>>> -- >>>>>> Regards, >>>>>> -Sivabalan >>>>>>=20 >>>>>=20 >>>>=20 >>>>=20 >>>> -- >>>> Regards, >>>> -Sivabalan >>>>=20 >>>=20 >>=20 >>=20 >> -- >> Regards, >> -Sivabalan >>=20