From notifications-return-215-archive-asf-public=cust-asf.ponee.io@httpd.apache.org Mon Apr 26 06:41:59 2021 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mxout1-he-de.apache.org (mxout1-he-de.apache.org [95.216.194.37]) by mx-eu-01.ponee.io (Postfix) with ESMTPS id 5C7EF180674 for ; Mon, 26 Apr 2021 08:41:59 +0200 (CEST) Received: from mail.apache.org (mailroute1-lw-us.apache.org [207.244.88.153]) by mxout1-he-de.apache.org (ASF Mail Server at mxout1-he-de.apache.org) with SMTP id DCE29605BF for ; Mon, 26 Apr 2021 06:41:55 +0000 (UTC) Received: (qmail 47540 invoked by uid 500); 26 Apr 2021 06:41:55 -0000 Mailing-List: contact notifications-help@httpd.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@httpd.apache.org Delivered-To: mailing list notifications@httpd.apache.org Received: (qmail 47513 invoked by uid 99); 26 Apr 2021 06:41:54 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 26 Apr 2021 06:41:54 +0000 From: =?utf-8?q?GitBox?= To: notifications@httpd.apache.org Subject: =?utf-8?q?=5BGitHub=5D_=5Bhttpd=5D_I-Cat_commented_on_pull_request_=23181=3A?= =?utf-8?q?_change_2493_urls_=5BWait_for_Travis=5D_=F0=9F=9A=A7?= Message-ID: <161941931453.15632.3036911029167824832.asfpy@gitbox.apache.org> Date: Mon, 26 Apr 2021 06:41:54 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit References: In-Reply-To: I-Cat commented on pull request #181: URL: https://github.com/apache/httpd/pull/181#issuecomment-826108168 > This may have damaged the korean translations (diff in github looks suspicious) updates all the license/copyright headers for nearly every file, and hit at least 1 URL that had an explicit port 80 in it. It also means things like /server-status and /server-info examples don't work w/o TLS. I don't really see the added value to offset this. Reply to : @covener covener > Message: Yes Thank you for your input. Maybe changing all the URLs to https:// all at once was a little much. That's odd, I will check the diff and see what happened to the port. Also will close and revert. The only way I could test this was by a pull request. Is there a nother way I can test this before I make a pull request? Then I can verify a passing build. All advice is appreciated. Signed-off-by: I-CAT -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: notifications-unsubscribe@httpd.apache.org For additional commands, e-mail: notifications-help@httpd.apache.org