From notifications-return-185-archive-asf-public=cust-asf.ponee.io@httpd.apache.org Thu Mar 11 15:28:55 2021 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mxout1-ec2-va.apache.org (mxout1-ec2-va.apache.org [3.227.148.255]) by mx-eu-01.ponee.io (Postfix) with ESMTPS id 9EC6A18062C for ; Thu, 11 Mar 2021 16:28:55 +0100 (CET) Received: from mail.apache.org (mailroute1-lw-us.apache.org [207.244.88.153]) by mxout1-ec2-va.apache.org (ASF Mail Server at mxout1-ec2-va.apache.org) with SMTP id DE01F427EC for ; Thu, 11 Mar 2021 15:28:54 +0000 (UTC) Received: (qmail 85742 invoked by uid 500); 11 Mar 2021 15:28:54 -0000 Mailing-List: contact notifications-help@httpd.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@httpd.apache.org Delivered-To: mailing list notifications@httpd.apache.org Received: (qmail 85733 invoked by uid 99); 11 Mar 2021 15:28:54 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 11 Mar 2021 15:28:54 +0000 From: =?utf-8?q?GitBox?= To: notifications@httpd.apache.org Subject: =?utf-8?q?=5BGitHub=5D_=5Bhttpd=5D_notroj_commented_on_a_change_in_pull_requ?= =?utf-8?q?est_=23177=3A_Add_SSL=5F=7BCLIENT=2CSERVER=7D=5FB64CERT?= Message-ID: <161547653455.15632.11469529425332703348.asfpy@gitbox.apache.org> Date: Thu, 11 Mar 2021 15:28:54 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit References: In-Reply-To: notroj commented on a change in pull request #177: URL: https://github.com/apache/httpd/pull/177#discussion_r592458181 ########## File path: modules/ssl/ssl_engine_vars.c ########## @@ -71,6 +76,21 @@ static int ssl_is_https(conn_rec *c) return sslconn && sslconn->ssl; } +#if APR_VERSION_AT_LEAST(1,7,0) +static const char *ssl_var_lookup_ssl_cert_b64url(apr_pool_t *p, X509 *xs) Review comment: Thanks a lot for the review! ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: notifications-unsubscribe@httpd.apache.org For additional commands, e-mail: notifications-help@httpd.apache.org