Mailing-List: contact modules-dev-help@httpd.apache.org; run by ezmlm
Precedence: bulk
Reply-To: modules-dev@httpd.apache.org
Received-SPF: pass (nike.apache.org: domain of jmarantz@google.com designates
 209.85.219.53 as permitted sender)
MIME-Version: 1.0
In-Reply-To: 
 <CANOjuGGw3L+qV9Mtfg0fez3cApRpdJBgbdWqVTTq+HEwgoJ1xA@mail.gmail.com>
References: 
 <CANOjuGEBEJr+uTH=1WoA+7+n+xsMEs8S9uEauHisE8tyi30mVQ@mail.gmail.com>
 <CAGKR+ECATQiw21G-01Vs1Jx4nPykGdm4No7PL4dqXtpH+R=HOg@mail.gmail.com>
 <01F77544-0720-4DDA-AF74-289BA1758B93@jaguNET.com>
 <CAGKR+ECf4oKdg1daZ5UL-=dgf2wA+-e54NDxS3zdJ=3XSPx2LQ@mail.gmail.com>
 <CANOjuGGw3L+qV9Mtfg0fez3cApRpdJBgbdWqVTTq+HEwgoJ1xA@mail.gmail.com>
From: Joshua Marantz <jmarantz@google.com>
Date: Wed, 1 May 2013 12:41:13 -0400
Message-ID: 
 <CAGKR+EDSSTsTGFXPcXiNjDFAcGQd2vVzUwssNcpQpV+GZ=qovQ@mail.gmail.com>
Subject: Re: Apache Buckets and Brigade
To: "modules-dev@httpd.apache.org" <modules-dev@httpd.apache.org>
Content-Type: multipart/alternative; boundary=089e011845f86f2b5c04dbaaca30

--089e011845f86f2b5c04dbaaca30
Content-Type: text/plain; charset=ISO-8859-1

On Wed, May 1, 2013 at 12:14 PM, Sindhi Sindhi <sindhi.for@gmail.com> wrote:

> Thanks to all for the reply.
>
> Josh, the concern I mentioned was, we may not want mod_pagespeed to modify
> the in-memory HTML content. The only change we may want to see in our HTML
> will be that the old strings are replaced by the new strings after applying
> our business logic which is already done by the C++ filter module I have
> written. This C++ filter implements all our business logic and takes an
> input buffer that is expected to be the entire HTML file content. So the
>

Yeah the filter I gave you gives you only a block of HTML characters.  E.g.
if you have
  <div>a b c d <i>e</i> f</div>
then you'll get this as 3 calls to Characters: "a b c d ", "e", and " f".
 Other than that, the Characters method I pointed you to has exactly the
interface you asked for: it gets you an entire block of HTML text in one
modifiable std::string which you can mutate at will.  And it irons out all
the brigade stuff for you.

You can configure mod_pagespeed to run just one filter so no other
modifications are made.

But it looks like you probably need to read Nick's book.  You can also read
mod_deflate.c or one of the other content-modifying filters such as mod_sed
or mod_substitute.

-Josh

--089e011845f86f2b5c04dbaaca30--