Mailing-List: contact modules-dev-help@httpd.apache.org; run by ezmlm
Precedence: bulk
Reply-To: modules-dev@httpd.apache.org
Received-SPF: pass (athena.apache.org: domain of jasonfister@gmail.com
 designates 72.14.204.168 as permitted sender)
DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=gamma;
        h=message-id:date:from:to:subject:in-reply-to:mime-version
         :content-type:references;
        b=bmFGedtnVIFgTkULqB/nNHxCYVBg0XoNqPHCm1htKO7P56v7t7SJpOzNl6JpmsCN/A
         +FkXEZ7Q+fsKCSG0GNr39ydB1/epP2WUbHu51cNsQE9L21upsLrSRfkcpY/jVeMpiCW0
         OHX7nDYa3P+UlvEpz8NNLSkfn7ZKOgvlvYMFM=
Message-ID: <98b241bd0807171815m216bab44o223404fa2bf375a8@mail.gmail.com>
Date: Thu, 17 Jul 2008 21:15:39 -0400
From: "Jason Fister" <jasonfister@gmail.com>
To: modules-dev@httpd.apache.org
Subject: Re: ap_get_client_block vs bucket brigades
In-Reply-To: <20170a030807171452w98a6addna1b7d139650b9289@mail.gmail.com>
MIME-Version: 1.0
Content-Type: multipart/alternative;
	boundary="----=_Part_7983_14948584.1216343739946"
References: <98b241bd0807171206o6e1a6b4ai8d85f57bf7b68f45@mail.gmail.com>
	 <20170a030807171452w98a6addna1b7d139650b9289@mail.gmail.com>

------=_Part_7983_14948584.1216343739946
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

Sorin,

On Thu, Jul 17, 2008 at 5:52 PM, Sorin Manolache <sorinm@gmail.com> wrote:

> Just a caveat. Loop like this:
>
> while ((n = ap_get_client_block()) > 0)
>  ...
>
> and not
>
> while (already_read < request->remaining) {
>   n = ap_get_client_block();
>   alread_read += n;
> }
>

Thanks for pointing it out. I am infact looping like ur first example.


>
> request->remaining may be misleading, for example if the client PUSHes
> compressed data request->remaining will indicate the size of the
> compressed data while your module will most likely read the data that
> is already decompressed by the DEFLATE filter on the input filter
> chain.
>
> >  2. Will the use of bucket brigades have a positive impact on the
> >  performance?
>
> Most likely not.
>

Thanks for your help!


Jason

------=_Part_7983_14948584.1216343739946--