From dev-return-95956-archive-asf-public=cust-asf.ponee.io@httpd.apache.org Wed Jun 30 07:42:32 2021 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mxout1-he-de.apache.org (mxout1-he-de.apache.org [95.216.194.37]) by mx-eu-01.ponee.io (Postfix) with ESMTPS id CE21D18060E for ; Wed, 30 Jun 2021 09:42:32 +0200 (CEST) Received: from mail.apache.org (mailroute1-lw-us.apache.org [207.244.88.153]) by mxout1-he-de.apache.org (ASF Mail Server at mxout1-he-de.apache.org) with SMTP id 277776196A for ; Wed, 30 Jun 2021 07:42:31 +0000 (UTC) Received: (qmail 59196 invoked by uid 500); 30 Jun 2021 07:42:29 -0000 Mailing-List: contact dev-help@httpd.apache.org; run by ezmlm Precedence: bulk Reply-To: dev@httpd.apache.org list-help: list-unsubscribe: List-Post: List-Id: Delivered-To: mailing list dev@httpd.apache.org Received: (qmail 59186 invoked by uid 99); 30 Jun 2021 07:42:29 -0000 Received: from spamproc1-he-de.apache.org (HELO spamproc1-he-de.apache.org) (116.203.196.100) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 30 Jun 2021 07:42:29 +0000 Received: from localhost (localhost [127.0.0.1]) by spamproc1-he-de.apache.org (ASF Mail Server at spamproc1-he-de.apache.org) with ESMTP id 59E181FF3A1 for ; Wed, 30 Jun 2021 07:42:28 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamproc1-he-de.apache.org X-Spam-Flag: NO X-Spam-Score: -3.297 X-Spam-Level: X-Spam-Status: No, score=-3.297 tagged_above=-999 required=6.31 tests=[DKIMWL_WL_HIGH=-0.698, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, POISEN_SPAM_PILL_3=0.1, RCVD_IN_HOSTKARMA_W=-2.5, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_PASS=-0.001] autolearn=disabled Authentication-Results: spamproc1-he-de.apache.org (amavisd-new); dkim=pass (1024-bit key) header.d=redhat.com Received: from mx1-he-de.apache.org ([116.203.227.195]) by localhost (spamproc1-he-de.apache.org [116.203.196.100]) (amavisd-new, port 10024) with ESMTP id lppkspTKDN5T for ; Wed, 30 Jun 2021 07:42:28 +0000 (UTC) Received-SPF: Pass (mailfrom) identity=mailfrom; client-ip=216.205.24.124; helo=us-smtp-delivery-124.mimecast.com; envelope-from=jorton@redhat.com; receiver= Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by mx1-he-de.apache.org (ASF Mail Server at mx1-he-de.apache.org) with ESMTPS id CF5AA7FE7E for ; Wed, 30 Jun 2021 07:42:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1625038946; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=L3dBSExORsKVMqQ3HHwtGtg00pyDSaEboAi3Tt8H83g=; b=NRoX8Sp2vXwlULC2OFK8ytVZP27ZB22WlghNEcXLiOJ18lO1yGmh4qWIKUoL7r0Fo+BHwh 9oqnxSnGoZnV8WzYI+jDUAhCs6TslaLskQGaWcNiMKfE3UZMp7qFYYKIBHT+xL2oIlFJqI kFc92Vz+fErAtlAbDvSbIQOTjZoNMA0= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-43-O9fDc4iHNyWi8UBapXjxnw-1; Wed, 30 Jun 2021 03:42:24 -0400 X-MC-Unique: O9fDc4iHNyWi8UBapXjxnw-1 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id CB1D415347 for ; Wed, 30 Jun 2021 07:42:23 +0000 (UTC) Received: from lunaria.manyfish.co.uk (ovpn-112-98.rdu2.redhat.com [10.10.112.98]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 9CE476267C for ; Wed, 30 Jun 2021 07:42:23 +0000 (UTC) Received: from jorton by lunaria.manyfish.co.uk with local (Exim 4.94.2) (envelope-from ) id 1lyUrV-00028k-UO for dev@httpd.apache.org; Wed, 30 Jun 2021 08:42:21 +0100 Date: Wed, 30 Jun 2021 08:42:21 +0100 From: Joe Orton To: dev@httpd.apache.org Subject: Re: svn commit: r1891148 - in /httpd/httpd/trunk: include/ap_mmn.h include/util_filter.h modules/proxy/proxy_util.c server/util_filter.c Message-ID: Mail-Followup-To: dev@httpd.apache.org References: <20210629211621.AC53417A7B4@svn01-us-east.apache.org> MIME-Version: 1.0 In-Reply-To: <20210629211621.AC53417A7B4@svn01-us-east.apache.org> Organization: Registered in England and Wales under Company Registration No. 03798903 Directors: Michael Cunningham (US), Michael O'Neill (Ireland), Paul Argiry (US) X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=jorton@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Disposition: inline On Tue, Jun 29, 2021 at 09:16:21PM -0000, ylavic@apache.org wrote: > Author: ylavic > Date: Tue Jun 29 21:16:21 2021 > New Revision: 1891148 > > URL: http://svn.apache.org/viewvc?rev=1891148&view=rev > Log: > core: Write Completion (WC) bucket type. > > A WC bucket is meant to prevent buffering/coalescing filters from retaining > data, but unlike a FLUSH bucket it won't cause the core output filter to > block trying to flush anything before. Interesting. I think it would be helpful to have the semantics of this bucket type described in the header as well. So filters should treat a WC bucket the same as FLUSH in general? And specifically, filters are broken if they don't? It seems like an accident that this makes mod_ssl's coalesce filter flush, merely because it will flush for *any* metadata bucket type, but it didn't have to be designed that way. If so I wonder if it wouldn't be better to overload FLUSH for this, e.g. by having a FLUSH bucket with a non-NULL ->data pointer or something? The core knows it is special but everywhere else treats as FLUSH. (Seems we need bucket subclasses...) Regards, Joe