From dev-return-95860-archive-asf-public=cust-asf.ponee.io@httpd.apache.org Wed Jun 2 11:33:10 2021 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mxout1-ec2-va.apache.org (mxout1-ec2-va.apache.org [3.227.148.255]) by mx-eu-01.ponee.io (Postfix) with ESMTPS id 61D66180638 for ; Wed, 2 Jun 2021 13:33:10 +0200 (CEST) Received: from mail.apache.org (mailroute1-lw-us.apache.org [207.244.88.153]) by mxout1-ec2-va.apache.org (ASF Mail Server at mxout1-ec2-va.apache.org) with SMTP id 2A8284047B for ; Wed, 2 Jun 2021 11:33:09 +0000 (UTC) Received: (qmail 60884 invoked by uid 500); 2 Jun 2021 11:33:08 -0000 Mailing-List: contact dev-help@httpd.apache.org; run by ezmlm Precedence: bulk Reply-To: dev@httpd.apache.org list-help: list-unsubscribe: List-Post: List-Id: Delivered-To: mailing list dev@httpd.apache.org Received: (qmail 60874 invoked by uid 99); 2 Jun 2021 11:33:08 -0000 Received: from spamproc1-he-fi.apache.org (HELO spamproc1-he-fi.apache.org) (95.217.134.168) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 02 Jun 2021 11:33:08 +0000 Received: from localhost (localhost [127.0.0.1]) by spamproc1-he-fi.apache.org (ASF Mail Server at spamproc1-he-fi.apache.org) with ESMTP id CB936C0452 for ; Wed, 2 Jun 2021 11:33:07 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamproc1-he-fi.apache.org X-Spam-Flag: NO X-Spam-Score: -0.001 X-Spam-Level: X-Spam-Status: No, score=-0.001 tagged_above=-999 required=6.31 tests=[SPF_PASS=-0.001] autolearn=disabled Received: from mx1-he-de.apache.org ([116.203.227.195]) by localhost (spamproc1-he-fi.apache.org [95.217.134.168]) (amavisd-new, port 10024) with ESMTP id Da4LTcz-6Fw4 for ; Wed, 2 Jun 2021 11:33:07 +0000 (UTC) Received-SPF: Pass (mailfrom) identity=mailfrom; client-ip=217.91.35.233; helo=mail.greenbytes.de; envelope-from=stefan.eissing@greenbytes.de; receiver= Received: from mail.greenbytes.de (mail.greenbytes.de [217.91.35.233]) by mx1-he-de.apache.org (ASF Mail Server at mx1-he-de.apache.org) with ESMTPS id 166B47FF7E for ; Wed, 2 Jun 2021 11:33:07 +0000 (UTC) Received: by mail.greenbytes.de (Postfix, from userid 119) id 71DDD9847CE; Wed, 2 Jun 2021 13:33:06 +0200 (CEST) Received: from smtpclient.apple (unknown [84.157.191.80]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mail.greenbytes.de (Postfix) with ESMTPSA id C14DF9807AA for ; Wed, 2 Jun 2021 13:33:05 +0200 (CEST) From: Stefan Eissing Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable Mime-Version: 1.0 (Mac OS X Mail 14.0 \(3654.100.0.2.22\)) Subject: Re: mod_proxy / mod_ssl interworking Date: Wed, 2 Jun 2021 13:33:05 +0200 References: To: dev@httpd.apache.org In-Reply-To: Message-Id: X-Mailer: Apple Mail (2.3654.100.0.2.22) > Am 02.06.2021 um 13:29 schrieb jean-frederic clere = : >=20 > On 01/06/2021 19:37, Stefan Eissing wrote: >>> Am 01.06.2021 um 18:21 schrieb jean-frederic clere = : >>>=20 >>> On 01/06/2021 16:40, Stefan Eissing wrote: >>>>> Am 01.06.2021 um 16:39 schrieb Stefan Eissing = : >>>>>=20 >>>>> PR on trunk, for review and commenting: = https://github.com/apache/httpd/pull/190 >>>>>=20 >>>>> This change makes it possible to have more than one SSL module = handling proxy connections. The intention is to do this in a backward = compatible way, like the previous ap_ssl_* changes. >>>>>=20 >>>>> The addition of a `conn_rec->outgoing` flag, set for these = connections, makes it easy for any connection handling code to filter on = the types of connections it is interested in. >>>>>=20 >>>>> Our test suite runs fine with these changes. >>>> He said while Travis is still running...optimistic as always... >>>=20 >>> = https://github.com/apache/httpd/pull/190/commits/867fa126f21575f104a1717ac= 49eaf1d8a558d77#diff-5506c76bad00bf136938033783d8d966bc463de54a679d3a8a390= 621b7a793c1R131 >>>=20 >>> Should that be filled "automagically"? >> How would you advise in filling that out before I commit to trunk? >=20 > I was thinking of telling this build something like ignore the PR it = is for review but that is too complex for nearly no benefits. Sorry for = noises. No problem. It would be nice to have it clean, but allocating log = numbers on suspicion seems not worth it. Upon further testing with 2 ssl modules today, I discovered the need for = some changes which I will push most likely later today. Stefan=