From dev-return-95864-archive-asf-public=cust-asf.ponee.io@httpd.apache.org Thu Jun 3 20:37:16 2021 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mxout1-he-de.apache.org (mxout1-he-de.apache.org [95.216.194.37]) by mx-eu-01.ponee.io (Postfix) with ESMTPS id D387E180643 for ; Thu, 3 Jun 2021 22:37:16 +0200 (CEST) Received: from mail.apache.org (mailroute1-lw-us.apache.org [207.244.88.153]) by mxout1-he-de.apache.org (ASF Mail Server at mxout1-he-de.apache.org) with SMTP id D238061CD9 for ; Thu, 3 Jun 2021 20:37:15 +0000 (UTC) Received: (qmail 15061 invoked by uid 500); 3 Jun 2021 20:37:14 -0000 Mailing-List: contact dev-help@httpd.apache.org; run by ezmlm Precedence: bulk Reply-To: dev@httpd.apache.org list-help: list-unsubscribe: List-Post: List-Id: Delivered-To: mailing list dev@httpd.apache.org Received: (qmail 15051 invoked by uid 99); 3 Jun 2021 20:37:14 -0000 Received: from spamproc1-he-fi.apache.org (HELO spamproc1-he-fi.apache.org) (95.217.134.168) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 03 Jun 2021 20:37:14 +0000 Received: from localhost (localhost [127.0.0.1]) by spamproc1-he-fi.apache.org (ASF Mail Server at spamproc1-he-fi.apache.org) with ESMTP id 9A14AC0452 for ; Thu, 3 Jun 2021 20:37:13 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamproc1-he-fi.apache.org X-Spam-Flag: NO X-Spam-Score: -0.199 X-Spam-Level: X-Spam-Status: No, score=-0.199 tagged_above=-999 required=6.31 tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_PASS=-0.001] autolearn=disabled Authentication-Results: spamproc1-he-fi.apache.org (amavisd-new); dkim=pass (2048-bit key) header.d=gmail.com Received: from mx1-ec2-va.apache.org ([116.203.227.195]) by localhost (spamproc1-he-fi.apache.org [95.217.134.168]) (amavisd-new, port 10024) with ESMTP id q6a4Zup3hSqu for ; Thu, 3 Jun 2021 20:37:13 +0000 (UTC) Received-SPF: Pass (mailfrom) identity=mailfrom; client-ip=209.85.216.47; helo=mail-pj1-f47.google.com; envelope-from=ylavic.dev@gmail.com; receiver= Received: from mail-pj1-f47.google.com (mail-pj1-f47.google.com [209.85.216.47]) by mx1-ec2-va.apache.org (ASF Mail Server at mx1-ec2-va.apache.org) with ESMTPS id 749CFBD221 for ; Thu, 3 Jun 2021 20:37:12 +0000 (UTC) Received: by mail-pj1-f47.google.com with SMTP id z3-20020a17090a3983b029016bc232e40bso1184845pjb.4 for ; Thu, 03 Jun 2021 13:37:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to; bh=KGa1pQ4RwL3QcCiwCQpmd4ktIezOtk/k5HKJYaZ9mzA=; b=agth0o4ChZkOcSPkU8d2cu22/3s93pf0aYg4zAdwR3GFGe5ulmA0YVZ82hmv2oS06g ZL/bWNHqM1O5xN2FaUgmO6OHlIgUH9Njqdn1BtlsRSmaFwQrssORHiLz+s3T0CmtRAwg e8Rn4HnIaSN+Cn2VKOx1q8stTFehoAsxGNTOgGjNsuViz6nTqvYR5xfajXwUs1zoLX3z SQ7CqmypMvCH9yi2cIYEhXaK9h7aQAbQ6qPFdlxoJzVnSTZSwDkNDd1pAjgPZdlqQwAJ wkowr+rpzutgqGgWnf21P/NLD5j/u9elx08TCMJkZ2FlMQeDww8LXJXyObjHeSaTrxkd 6KBQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to; bh=KGa1pQ4RwL3QcCiwCQpmd4ktIezOtk/k5HKJYaZ9mzA=; b=Sbvbq6zYR6LGSJbk0zgOjy9ezBL5KSuawm0IYPKft3dLQfTBNf1fP8j3b+3buIoj79 hyE7BFqe2XIDmucJgoZX7IjF7BQld0Hb4iQ+fllUYj8DRcxVWNWtOrcAqKGw+XIusEa2 d5Hchj6xFMZKwQotb5Wcbwtmw+/ym4xu4SfmBpoB3OBDAYPRvORYQSriT2O7WkxDs/gZ BRE5SpHN8XKFLoFGE1bl+455cgnSyujnSaqG/r+nhUsYj3lQ7Iuep3HgUNhPuydVmecc V0GAv+/EaIJkoTk59Rmuhjl2qF15st5uEqxrIPhdCTqt/A3edYPGKuWZOcFoBfU9Ukwg DZVw== X-Gm-Message-State: AOAM533RmiUKs2d10e02bPiCmQ0BiEohG7kzB+NlWSynDOG/3fW5Gnf7 cRD7mPXj/ZabLYpkZle7c+1NsQhSwTxAGNeuYgwCD2v8nmM= X-Google-Smtp-Source: ABdhPJwPfSE27YecnQIl3VXtA6rcgRPxHuz8cqE5bN7A/bNm+HBJ2RMjTCEBVqr7VJxkaFZLK9hrnFbynFb06GPMZ2c= X-Received: by 2002:a17:902:d284:b029:106:64e4:6bed with SMTP id t4-20020a170902d284b029010664e46bedmr852659plc.73.1622752631278; Thu, 03 Jun 2021 13:37:11 -0700 (PDT) MIME-Version: 1.0 References: <60b91015c2de7_13ff9fc8dba6891330@travis-pro-tasks-55b986c4b9-g6h8w.mail> In-Reply-To: From: Yann Ylavic Date: Thu, 3 Jun 2021 22:36:59 +0200 Message-ID: Subject: Re: Broken: apache/httpd#1667 (2.4.x - 59393dd) To: httpd-dev Content-Type: multipart/mixed; boundary="00000000000025d0ae05c3e28aa2" --00000000000025d0ae05c3e28aa2 Content-Type: text/plain; charset="UTF-8" On Thu, Jun 3, 2021 at 8:27 PM Ruediger Pluem wrote: > > Looking at the stack trace, would we need to call apr_setup_signal_thread() (if we have APR_THREADS) before we run > ap_run_child_init and unblock all signals afterwards in case one of the init child hooks creates threads like mod_watchdog does? Agreed, what about the attached patch? Regards; Yann. --00000000000025d0ae05c3e28aa2 Content-Type: text/x-patch; charset="US-ASCII"; name="prefork_sigmask.diff" Content-Disposition: attachment; filename="prefork_sigmask.diff" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_kphczym40 SW5kZXg6IHNlcnZlci9tcG0vcHJlZm9yay9wcmVmb3JrLmMKPT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gc2VydmVy L21wbS9wcmVmb3JrL3ByZWZvcmsuYwkocmV2aXNpb24gMTg5MDQyMSkKKysrIHNlcnZlci9tcG0v cHJlZm9yay9wcmVmb3JrLmMJKHdvcmtpbmcgY29weSkKQEAgLTM3NiwxMSArMzc2LDIzIEBAIHN0 YXRpYyB2b2lkIHN0b3BfbGlzdGVuaW5nKGludCBzaWcpCiBzdGF0aWMgaW50IHJlcXVlc3RzX3Ro aXNfY2hpbGQ7CiBzdGF0aWMgaW50IG51bV9saXN0ZW5zb2NrcyA9IDA7CiAKKyNpZiBBUFJfSEFT X1RIUkVBRFMKK3N0YXRpYyB2b2lkIGNoaWxkX3NpZ21hc2soc2lnc2V0X3QgKm5ld19tYXNrLCBz aWdzZXRfdCAqb2xkX21hc2spCit7CisjaWYgZGVmaW5lZChTSUdQUk9DTUFTS19TRVRTX1RIUkVB RF9NQVNLKQorICAgIHNpZ3Byb2NtYXNrKFNJR19TRVRNQVNLLCBuZXdfbWFzaywgb2xkX21hc2sp OworI2Vsc2UKKyAgICBwdGhyZWFkX3NpZ21hc2soU0lHX1NFVE1BU0ssIG5ld19tYXNrLCBvbGRf bWFzayk7CisjZW5kaWYKK30KKyNlbmRpZgorCiBzdGF0aWMgdm9pZCBjaGlsZF9tYWluKGludCBj aGlsZF9udW1fYXJnLCBpbnQgY2hpbGRfYnVja2V0KQogewogI2lmIEFQUl9IQVNfVEhSRUFEUwog ICAgIGFwcl90aHJlYWRfdCAqdGhkID0gTlVMTDsKICAgICBhcHJfb3NfdGhyZWFkX3Qgb3N0aGQ7 CisgICAgc2lnc2V0X3Qgc2lnX21hc2s7CiAjZW5kaWYKICAgICBhcHJfcG9vbF90ICpwdHJhbnM7 CiAgICAgYXByX2FsbG9jYXRvcl90ICphbGxvY2F0b3I7CkBAIC00NDYsOCArNDU4LDMwIEBAIHN0 YXRpYyB2b2lkIGNoaWxkX21haW4oaW50IGNoaWxkX251bV9hcmcsIGludCBjaGlsCiAgICAgICAg IGNsZWFuX2NoaWxkX2V4aXQoQVBFWElUX0NISUxERkFUQUwpOwogICAgIH0KIAorI2lmIEFQUl9I QVNfVEhSRUFEUworICAgIC8qIFNhdmUgdGhlIHNpZ25hbCBtYXNrIGFuZCBVc2UgYXByX3NldHVw X3NpZ25hbF90aHJlYWQgdG8gYmxvY2sgYWxsCisgICAgICogdGhlIHNpZ25hbHMgZnJvbSBiZWlu ZyByZWNlaXZlZCBieSB0aHJlYWRzIHBvdGVudGlhbGx5IGNyZWF0ZWQgYnkKKyAgICAgKiBjaGls ZF9pbml0KCkgaG9va3MuCisgICAgICovCisgICAgY2hpbGRfc2lnbWFzayhOVUxMLCAmc2lnX21h c2spOworICAgIHsKKyAgICAgICAgYXByX3N0YXR1c190IHJ2OworICAgICAgICBydiA9IGFwcl9z ZXR1cF9zaWduYWxfdGhyZWFkKCk7CisgICAgICAgIGlmIChydiAhPSBBUFJfU1VDQ0VTUykgewor ICAgICAgICAgICAgYXBfbG9nX2Vycm9yKEFQTE9HX01BUkssIEFQTE9HX0VNRVJHLCBydiwgYXBf c2VydmVyX2NvbmYsIEFQTE9HTk8oKQorICAgICAgICAgICAgICAgICAgICAgICAgICJDb3VsZG4n dCBpbml0aWFsaXplIHNpZ25hbCB0aHJlYWQiKTsKKyAgICAgICAgICAgIGNsZWFuX2NoaWxkX2V4 aXQoQVBFWElUX0NISUxERkFUQUwpOworICAgICAgICB9CisgICAgfQorI2VuZGlmIC8qIEFQUl9I QVNfVEhSRUFEUyAqLworCiAgICAgYXBfcnVuX2NoaWxkX2luaXQocGNoaWxkLCBhcF9zZXJ2ZXJf Y29uZik7CiAKKyNpZiBBUFJfSEFTX1RIUkVBRFMKKyAgICAvKiBSZXN0b3JlIHRoZSBvcmlnaW5h bCBzaWduYWwgbWFzayBpbiB0aGUgbWFpbiBjaGlsZCB0aHJlYWQuICovCisgICAgY2hpbGRfc2ln bWFzaygmc2lnX21hc2ssIE5VTEwpOworI2VuZGlmCisKICAgICBhcF9jcmVhdGVfc2JfaGFuZGxl KCZzYmgsIHBjaGlsZCwgbXlfY2hpbGRfbnVtLCAwKTsKIAogICAgICh2b2lkKSBhcF91cGRhdGVf Y2hpbGRfc3RhdHVzKHNiaCwgU0VSVkVSX1JFQURZLCAocmVxdWVzdF9yZWMgKikgTlVMTCk7Cg== --00000000000025d0ae05c3e28aa2--