From dev-return-95912-archive-asf-public=cust-asf.ponee.io@httpd.apache.org Wed Jun 23 08:22:47 2021 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mxout1-ec2-va.apache.org (mxout1-ec2-va.apache.org [3.227.148.255]) by mx-eu-01.ponee.io (Postfix) with ESMTPS id E636D180636 for ; Wed, 23 Jun 2021 10:22:46 +0200 (CEST) Received: from mail.apache.org (mailroute1-lw-us.apache.org [207.244.88.153]) by mxout1-ec2-va.apache.org (ASF Mail Server at mxout1-ec2-va.apache.org) with SMTP id F2109417C8 for ; Wed, 23 Jun 2021 08:22:45 +0000 (UTC) Received: (qmail 32606 invoked by uid 500); 23 Jun 2021 08:22:45 -0000 Mailing-List: contact dev-help@httpd.apache.org; run by ezmlm Precedence: bulk Reply-To: dev@httpd.apache.org list-help: list-unsubscribe: List-Post: List-Id: Delivered-To: mailing list dev@httpd.apache.org Received: (qmail 32596 invoked by uid 99); 23 Jun 2021 08:22:45 -0000 Received: from spamproc1-he-de.apache.org (HELO spamproc1-he-de.apache.org) (116.203.196.100) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 23 Jun 2021 08:22:45 +0000 Received: from localhost (localhost [127.0.0.1]) by spamproc1-he-de.apache.org (ASF Mail Server at spamproc1-he-de.apache.org) with ESMTP id 6F7A61FF47F for ; Wed, 23 Jun 2021 08:22:44 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamproc1-he-de.apache.org X-Spam-Flag: NO X-Spam-Score: -0.199 X-Spam-Level: X-Spam-Status: No, score=-0.199 tagged_above=-999 required=6.31 tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_PASS=-0.001] autolearn=disabled Authentication-Results: spamproc1-he-de.apache.org (amavisd-new); dkim=pass (2048-bit key) header.d=gmail.com Received: from mx1-ec2-va.apache.org ([116.203.227.195]) by localhost (spamproc1-he-de.apache.org [116.203.196.100]) (amavisd-new, port 10024) with ESMTP id x6KXGEtCj-J0 for ; Wed, 23 Jun 2021 08:22:44 +0000 (UTC) Received-SPF: Pass (mailfrom) identity=mailfrom; client-ip=209.85.218.51; helo=mail-ej1-f51.google.com; envelope-from=jblond@gmail.com; receiver= Received: from mail-ej1-f51.google.com (mail-ej1-f51.google.com [209.85.218.51]) by mx1-ec2-va.apache.org (ASF Mail Server at mx1-ec2-va.apache.org) with ESMTPS id 93535BC488 for ; Wed, 23 Jun 2021 08:22:43 +0000 (UTC) Received: by mail-ej1-f51.google.com with SMTP id bu12so2788734ejb.0 for ; Wed, 23 Jun 2021 01:22:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to; bh=0HHerELu0HCKqvzeySbF4IuXEMUlY2aSlfHHdF+o8hQ=; b=NXTKDhlqy+smWJ0wQf2DYk0do2/Qfiu3kBeW7Ay9d2DhaudxIWMKwS+JPIajCJ+YpB iZsxh2VdEEowDA4PVeQhXF6rcpGK0N5HemrwPgtRiExNaQpWrYdsTE8BQdmjuQ3bztq9 vY4kZMLr3DgUy8ktRTIPwFTyMqCSYBf+Ut3bFANHjV+i8ffFhO/CSvIXoTcEvdw+gEaB ZAIsN/QZ+ADzVd8vL40T6yGI3cKQwaCN1q9BFownC/ga63SMwzB8AoXxuwu+zDJhNg1t 5q52BtmZLxrSqUrwXjZUokmgteMmWUbyEpR0CnChcGByhvK1vGOZ4bapiwBLFdQqKI5F k4/w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to; bh=0HHerELu0HCKqvzeySbF4IuXEMUlY2aSlfHHdF+o8hQ=; b=JwaEVGLMwf3VMQn3kPhG/SOIvzsfJ6WiD/NNq4JJepCfSE6AO/D0mV3xArqVmIlWxP KjwMuqJtvuTYp3DL7YVvM4RxkYH34Sp1WwzCXyOB79on1QTHZT7tMR+QXl9c7CdfZt4B l9qIBzkyhwBrDGEG3oveAt3GyESndxHAKqnBhf1zxZBLIILU63M9y+mGomQTclIc8q1e B3lX5E8XRzhA53/Sp9dg1XC+bQEM+k8VxFqzcEwDjdUqwTpLlrfLtKF2PJKau04jChgH ZwRv7zFQDvsauE1Hzir4ef6sqefg3LtJ5Lhj7AfhXg7QaL9dg11zaBEMNa2Qib55Z0c6 MZkw== X-Gm-Message-State: AOAM531V0T0354cVtT8vYpXcaiZFPp5OJ/qCZdIe+VCSTIX5HUJBFTCZ TNx4FV3JtKTbJ8r6lCzk1iIL9WPoUQ7qsq0BqJo5Z2sWPd6C95+PG7mdeHb0 X-Google-Smtp-Source: ABdhPJwEACYQVWKlehr7Qx8QoGXPROo7Ugd2TW5/DdMydbaECAj87Elt5hWUyuxCJsA90NhAF029qmHcy2nN+KZhDrE= X-Received: by 2002:a17:907:1ca0:: with SMTP id nb32mr8806952ejc.105.1624436562621; Wed, 23 Jun 2021 01:22:42 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Mario Brandt Date: Wed, 23 Jun 2021 08:22:31 +0000 Message-ID: Subject: Re: Question about source code comment To: dev@httpd.apache.org Content-Type: text/plain; charset="UTF-8" Hi Nikita, that was done by Daniel Gruno aka Humbedooh. Maybe he still knows why I added that comment in 2014. Cheers Mario On Tue, 8 Jun 2021 at 08:43, Nikita Popov wrote: > > Hello. While investigating source codes I've found the following > comment for modules/lua/lua_request.c::lua_ap_get_active_config > function - "Hack, hack, hack...! TODO: Make this actually work > properly". Could anyone explain what needs to be fixed for this > function? I'm looking for a contributor's mission as suggested by the > STATUS file. Thanks in advance!